ci: retry notarization on transient poll failures - #212
Merged
Conversation
Apple's notary status endpoint occasionally drops the polling connection (-1009), which killed notarytool --wait mid-submission. Retry the whole submit-and-wait up to 3 times and bound each attempt with --timeout 30m so a transient network blip doesn't fail an otherwise-successful release.
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe macOS release workflow now retries notarization up to three times. Each attempt has a 30-minute timeout and failed attempts wait 30 seconds before retrying. The workflow fails after cleanup if no attempt succeeds. ChangesmacOS notarization retry handling
Estimated code review effort: 3 (Moderate) | ~15–30 minutes Possibly related PRs
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apple's notary status endpoint occasionally drops the polling connection (
-1009), which killednotarytool --waitmid-submission (this failed panoply's v0.1.1 release build after Apple had already accepted the submission). Retries the whole submit-and-wait up to 3× with--timeout 30mper attempt so a transient blip doesn't fail an otherwise-successful release.Summary by CodeRabbit