Add AirspeedFit#330
Open
robertlong13 wants to merge 1 commit into
Open
Conversation
9 tasks
IamPete1
reviewed
Jul 14, 2026
IamPete1
left a comment
IamPete1
left a comment
Member
There was a problem hiding this comment.
This is what Claude thinks:
I'll leave you to decide how much you care about those issues. I have had a play about and I have not been able to get it to break, and its in dev, so I'm inclined to just merge it.
I thought there was a python script for this somewhere, but I have looked in AP and in pyMAVLink and I can't find it. I was just thinking to run the same log and make sure the result is similar to this.
| return isFinite(v) ? v : null | ||
| } | ||
|
|
||
| // Carbonix-specific behaviour, sneaked harmlessly into upstream: our GCS sends |
Member
There was a problem hiding this comment.
I have spotted the sneaking, but as the comment says, I think its harmless.
| // UTC Date for a log timestamp (seconds), from the GPS week/millisecond of the | ||
| // first 3D fix (matching JsDataflashParser's own conversion). Returns null if the | ||
| // log has no usable GPS time. | ||
| function gps_utc_at(log, t_seconds) { |
Member
There was a problem hiding this comment.
You should just be able to do log.extractStartTime() to get it in a JS date object.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Log-based airspeed calibration tool, inspired by the built-in autocal.
I've been testing this out for about a week and it's working great.