Skip to content

AGP 4.2.0 support - #137

Open
powturns wants to merge 1 commit into
Archinamon:masterfrom
powturns:agp-420
Open

AGP 4.2.0 support#137
powturns wants to merge 1 commit into
Archinamon:masterfrom
powturns:agp-420

Conversation

@powturns

@powturns powturns commented May 5, 2021

Copy link
Copy Markdown

Fix build errors for android google plugin 4.2.0

https://developer.android.com/studio/releases/gradle-plugin#4-2-0

@eyedol

eyedol commented May 20, 2021

Copy link
Copy Markdown
Contributor

Does it work with AGP 4.2.1 also? I believe so.

@powturns

Copy link
Copy Markdown
Author

It seems to, but I haven't tested extensively.

For anyone else waiting for this MR to go in, you can use this dependency in the mean time:
com.github.Archinamon:android-gradle-aspectj:PR137-SNAPSHOT

Just make sure you have the jitpack maven repo in your project.

@dmitrikudrenko

Copy link
Copy Markdown

@eyedol Will you merge it?

@davidwong

Copy link
Copy Markdown

FYI this seems to work with AGP 7.0.0-beta03 using the standard version of the plugin (not fully tested, just tried with simple aj file). Just be aware that if using java 11 in the project, that the plugin doesn't seem to pass on the java module options to ajc.
So using this config was OK:
aspectj {
ajc = '1.9.6'
java = JavaVersion.VERSION_1_8
}
However using 'java = JavaVersion.VERSION_11' caused problems in the aj file with a message about ambiguous classes.

@eyedol

eyedol commented Jun 28, 2021

Copy link
Copy Markdown
Contributor

Will you merge it?

@dmitrikudrenko I won't be able to merge it as I don't have the ability to do so 😢

@jiechic

jiechic commented Aug 13, 2021

Copy link
Copy Markdown

FYI this seems to work with AGP 7.0.0-beta03 using the standard version of the plugin (not fully tested, just tried with simple aj file). Just be aware that if using java 11 in the project, that the plugin doesn't seem to pass on the java module options to ajc.
So using this config was OK:
aspectj {
ajc = '1.9.6'
java = JavaVersion.VERSION_1_8
}
However using 'java = JavaVersion.VERSION_11' caused problems in the aj file with a message about ambiguous classes.

test confing

aspectj {
//    dryRun false // default value
//    compileTests true // default value

    ajc '1.9.5' // default value
    java = JavaVersion.VERSION_11 // default value
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants