fix: make Actions Ring selectable in action pickers - #958
Open
the-long-ride wants to merge 4 commits into
Open
Conversation
Greptile SummaryThe PR makes Actions Ring selectable from normal and gesture action pickers while retaining validation that prevents recursive ring entries.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| crates/openlogi-core/src/binding/action.rs | Makes ShowActionsRing pickable through the shared catalog while leaving RingAction validation unchanged. |
| crates/openlogi-core/src/binding/tests.rs | Verifies catalog availability and continued recursive-trigger rejection. |
| crates/openlogi-desktop/src/features/mouse/picker.rs | Adds coverage confirming the gesture picker receives Actions Ring from the shared catalog. |
Reviews (4): Last reviewed commit: "Merge branch 'master' into fix/show-acti..." | Re-trigger Greptile
davidbudnick
approved these changes
Aug 25, 2026
Collaborator
|
@the-long-ride Can you please fill out the description of the PR? |
Contributor
Author
I'd thought that greptile-apps already did it well =]] Updated btw. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary changes:
Now that option will be listed here:
