Skip to content

fix: make Actions Ring selectable in action pickers - #958

Open
the-long-ride wants to merge 4 commits into
AprilNEA:masterfrom
the-long-ride:fix/show-actions-ring-picker
Open

fix: make Actions Ring selectable in action pickers#958
the-long-ride wants to merge 4 commits into
AprilNEA:masterfrom
the-long-ride:fix/show-actions-ring-picker

Conversation

@the-long-ride

@the-long-ride the-long-ride commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Summary changes:

  • Adds ShowActionsRing to the shared action catalog.
  • Verifies normal and gesture picker availability.
  • Retains RingAction validation against recursive Actions Ring entries.

Now that option will be listed here:
image

@greptile-apps

greptile-apps Bot commented Aug 25, 2026

Copy link
Copy Markdown

Greptile Summary

The PR makes Actions Ring selectable from normal and gesture action pickers while retaining validation that prevents recursive ring entries.

  • Adds ShowActionsRing to the shared action catalog.
  • Adds coverage for shared and gesture-picker availability.
  • Continues rejecting ShowActionsRing when constructing a RingAction.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename Overview
crates/openlogi-core/src/binding/action.rs Makes ShowActionsRing pickable through the shared catalog while leaving RingAction validation unchanged.
crates/openlogi-core/src/binding/tests.rs Verifies catalog availability and continued recursive-trigger rejection.
crates/openlogi-desktop/src/features/mouse/picker.rs Adds coverage confirming the gesture picker receives Actions Ring from the shared catalog.

Reviews (4): Last reviewed commit: "Merge branch 'master' into fix/show-acti..." | Re-trigger Greptile

@davidbudnick

Copy link
Copy Markdown
Collaborator

@the-long-ride Can you please fill out the description of the PR?

@davidbudnick davidbudnick added type: bug Something is broken or behaves incorrectly platform: all Cross-platform issue labels Aug 25, 2026
@the-long-ride

Copy link
Copy Markdown
Contributor Author

@the-long-ride Can you please fill out the description of the PR?

I'd thought that greptile-apps already did it well =]]

Updated btw.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

platform: all Cross-platform issue type: bug Something is broken or behaves incorrectly

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants