fix(gui): wrap the About page's link row instead of clipping it - #885
Open
crnst8 wants to merge 1 commit into
Open
fix(gui): wrap the About page's link row instead of clipping it#885crnst8 wants to merge 1 commit into
crnst8 wants to merge 1 commit into
Conversation
The row of links on Settings > About overflows the card. "Copy Diagnostics" is last in the row so it gets cut in half, and the 56px logo disappears: flexbox shrinks what it can to make room, and the image is the only item that will shrink, so it collapses to zero width. Widening the window from 840 to 920 only bought slack. Any locale, font or DPI past the available width brings the clipping back. Wrap the row, let the column shrink so it can, and pin the logo so it is not squeezed to make room.
crnst8
marked this pull request as ready for review
August 24, 2026 02:04
Greptile SummaryThe PR corrects overflow in the Settings About hero by allowing its link row to wrap while preserving the logo’s dimensions.
Confidence Score: 5/5The PR appears safe to merge with no actionable correctness, security, or maintainability issues identified. The layout changes consistently constrain the flexible content column, preserve the fixed-size logo, and permit the variable-width link row to wrap without introducing a demonstrated clipping or sizing failure.
|
| Filename | Overview |
|---|---|
| crates/openlogi-desktop/src/windows/settings/about.rs | Applies complementary flex sizing and wrapping constraints to keep the About hero’s logo and links visible at constrained widths. |
Reviews (1): Last reviewed commit: "fix(gui): wrap the About page's link row..." | Re-trigger Greptile
davidbudnick
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On Settings > About, the row of links overflows the card. Two things go wrong
at once, and both come from the same cause:
The row cannot wrap and cannot shrink, so it overflows. Flexbox then shrinks
what it can to make room, and the logo is the only item that will shrink, so it
collapses to zero width. That is why the hero renders with no icon at all.
The window width was raised from 840 to 920 earlier to stop the clipping on
Windows, but that only buys slack. Any locale, font or DPI that pushes the
labels past the available width brings it back, which is what happens on macOS
at the current 920 floor.
Let the row wrap, and stop the logo being shrunk to make room for it.
Changes
openlogi-desktop: addflex_wrap()to the About hero's link row so thebuttons move to a second line rather than overflowing.
openlogi-desktop: addmin_w_0()andflex_1()to the column holding thatrow. Without
min_w_0a flex child will not shrink below its content width,so the row would still overflow rather than wrap.
openlogi-desktop: addflex_shrink_0()to the logo so it keeps its 56pxsquare instead of collapsing when the row is tight.
Testing
cargo fmt --all -- --checkRUSTFLAGS="-D warnings" cargo clippy --workspace --all-targets -- -D warningscargo test --workspace(1058 passed, 2 ignored)RUSTDOCFLAGS="-D warnings" cargo doc --workspace --no-deps --document-private-items --exclude openlogi-ui --exclude openlogi-desktop --exclude openlogi-overlay --exclude openlogi-agentcargo xtask ci— 6 passed, 5 skippedproxy, wasm (portable crates)
before, "Copy Diagnostics" is clipped and the logo is missing; after, the row
wraps to a second line and the logo renders.
Screenshots: before (0.7.10 release) and after, both on the About page.
before
after