Skip to content

fix(gui): wrap the About page's link row instead of clipping it - #885

Open
crnst8 wants to merge 1 commit into
AprilNEA:masterfrom
crnst8:fix/about-link-row-wrap
Open

fix(gui): wrap the About page's link row instead of clipping it#885
crnst8 wants to merge 1 commit into
AprilNEA:masterfrom
crnst8:fix/about-link-row-wrap

Conversation

@crnst8

@crnst8 crnst8 commented Aug 24, 2026

Copy link
Copy Markdown

Summary

On Settings > About, the row of links overflows the card. Two things go wrong
at once, and both come from the same cause:

  • "Copy Diagnostics" is last in the row, so it gets cut in half.
  • The 56px app logo disappears entirely.

The row cannot wrap and cannot shrink, so it overflows. Flexbox then shrinks
what it can to make room, and the logo is the only item that will shrink, so it
collapses to zero width. That is why the hero renders with no icon at all.

The window width was raised from 840 to 920 earlier to stop the clipping on
Windows, but that only buys slack. Any locale, font or DPI that pushes the
labels past the available width brings it back, which is what happens on macOS
at the current 920 floor.

Let the row wrap, and stop the logo being shrunk to make room for it.

Changes

  • openlogi-desktop: add flex_wrap() to the About hero's link row so the
    buttons move to a second line rather than overflowing.
  • openlogi-desktop: add min_w_0() and flex_1() to the column holding that
    row. Without min_w_0 a flex child will not shrink below its content width,
    so the row would still overflow rather than wrap.
  • openlogi-desktop: add flex_shrink_0() to the logo so it keeps its 56px
    square instead of collapsing when the row is tight.

Testing

  • cargo fmt --all -- --check
  • RUSTFLAGS="-D warnings" cargo clippy --workspace --all-targets -- -D warnings
  • cargo test --workspace (1058 passed, 2 ignored)
  • RUSTDOCFLAGS="-D warnings" cargo doc --workspace --no-deps --document-private-items --exclude openlogi-ui --exclude openlogi-desktop --exclude openlogi-overlay --exclude openlogi-agent
  • cargo xtask ci — 6 passed, 5 skipped
  • Not run on this host: shell, tests (linux), cargo-deny, clippy (windows)
    proxy, wasm (portable crates)
  • Verified by eye on macOS, external display at 1.0 scale, default 920px window:
    before, "Copy Diagnostics" is clipped and the logo is missing; after, the row
    wraps to a second line and the logo renders.

Screenshots: before (0.7.10 release) and after, both on the About page.

before

rel

after

dev

The row of links on Settings > About overflows the card. "Copy
Diagnostics" is last in the row so it gets cut in half, and the 56px
logo disappears: flexbox shrinks what it can to make room, and the
image is the only item that will shrink, so it collapses to zero width.

Widening the window from 840 to 920 only bought slack. Any locale, font
or DPI past the available width brings the clipping back.

Wrap the row, let the column shrink so it can, and pin the logo so it
is not squeezed to make room.
@crnst8
crnst8 marked this pull request as ready for review August 24, 2026 02:04
@crnst8
crnst8 requested a review from AprilNEA as a code owner August 24, 2026 02:04
@greptile-apps

greptile-apps Bot commented Aug 24, 2026

Copy link
Copy Markdown

Greptile Summary

The PR corrects overflow in the Settings About hero by allowing its link row to wrap while preserving the logo’s dimensions.

  • Makes the content column shrink within the available width.
  • Allows localized or wide link labels to wrap onto additional lines.
  • Prevents the 56px logo from collapsing under flex pressure.

Confidence Score: 5/5

The PR appears safe to merge with no actionable correctness, security, or maintainability issues identified.

The layout changes consistently constrain the flexible content column, preserve the fixed-size logo, and permit the variable-width link row to wrap without introducing a demonstrated clipping or sizing failure.

Important Files Changed

Filename Overview
crates/openlogi-desktop/src/windows/settings/about.rs Applies complementary flex sizing and wrapping constraints to keep the About hero’s logo and links visible at constrained widths.

Reviews (1): Last reviewed commit: "fix(gui): wrap the About page's link row..." | Re-trigger Greptile

@davidbudnick davidbudnick added this to the v0.8.0 milestone Aug 24, 2026
@davidbudnick davidbudnick added type: bug Something is broken or behaves incorrectly area: gui Graphical user interface labels Aug 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: gui Graphical user interface type: bug Something is broken or behaves incorrectly

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants