Make uptime sensor human-readable - #72
kernelpanic85 wants to merge 2 commits into
Conversation
Updates the R-PRO-1 uptime reporting to display uptime in days, hours, minutes, and seconds format instead of raw seconds.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. WalkthroughThe ESPHome configuration now formats uptime in the raw-value callback. The ChangesUptime display
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit watches seconds flow Comment |
Refactored uptime calculation logic to use on_raw_value event and removed previous lambda implementation.
Version: 26.3.2.1
What does this implement/fix?
Updates the R-PRO-1 uptime reporting to display uptime in days, hours, minutes, and seconds format instead of raw seconds.
Note: Might want to consider pushing this out to other devices if they all have the same uptime config currently.
Types of changes
Checklist / Checklijst:
If user-visible functionality or configuration variables are added/modified:
Summary by CodeRabbit
New Features
Changes