Skip to content

[esphome] Modernise board spec, web server v3, remove legacy options - #27

Merged
TrevorSchirmer merged 3 commits into
betafrom
esphome-modernisation
Feb 27, 2026
Merged

TrevorSchirmer merged 3 commits into
betafrom
esphome-modernisation

Conversation

@bharvey88

@bharvey88 bharvey88 commented Feb 25, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Remove redundant esp32: board: esp32-c6-devkitm-1 string from Core.yaml (variant: esp32c6 + flash_size: 8MB already present and sufficient)
  • Add version: 3 to web_server: in Core.yaml (inherited by both device variants)
  • Remove platformio_options: board_build.flash_mode: dio from PUMP-1.yaml and PUMP-1_Minimal.yaml
  • Remove legacy BLE wifi hooks (on_connect: ble.disable / on_disconnect: ble.enable) from PUMP-1.yaml

Test plan

  • esphome config validates cleanly for PUMP-1.yaml and PUMP-1_Minimal.yaml
  • OTA flash succeeds on device
  • Web server UI loads at device IP

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes

Summary by CodeRabbit

  • New Features

    • Added WiFi IP address, ESPHome version, and firmware version sensor information.
  • Updates

    • Added explicit web server version configuration.
    • Updated pump control sequence behavior.
    • Removed device board specification and WiFi automation configurations.

…ions

- Remove redundant esp32 board string (variant + flash_size already present)
- Add web_server version: 3 to Core.yaml
- Remove platformio_options board_build.flash_mode from both device YAMLs
- Remove legacy BLE wifi on_connect/on_disconnect hooks from PUMP-1.yaml
@coderabbitai

coderabbitai Bot commented Feb 25, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0e79266 and d000ca3.

📒 Files selected for processing (3)
  • Integrations/ESPHome/Core.yaml
  • Integrations/ESPHome/PUMP-1.yaml
  • Integrations/ESPHome/PUMP-1_Minimal.yaml
💤 Files with no reviewable changes (2)
  • Integrations/ESPHome/PUMP-1_Minimal.yaml
  • Integrations/ESPHome/PUMP-1.yaml

Walkthrough

These changes modify ESPHome configuration files to enhance monitoring capabilities and simplify device-specific settings. The main Core.yaml configuration gains web server versioning, diagnostic text sensors for WiFi information and firmware version, and a reordered pump control sequence. Platform-specific compilation options and WiFi automation blocks are removed from device configurations.

Changes

Cohort / File(s) Summary
Core Configuration Enhancement
Integrations/ESPHome/Core.yaml
Added web_server.version: 3, introduced text_sensor block with WiFi IP address, ESPHome version, and Apollo Firmware Version sensors. Updated pumpUntilFull script to enable stop_pump_when_full before turning on pump_control. Removed esp32.board specification.
Device Configuration Simplification
Integrations/ESPHome/PUMP-1.yaml, Integrations/ESPHome/PUMP-1_Minimal.yaml
Removed platformio_options block (board_build.flash_mode: dio) and wifi on_connect/on_disconnect automation blocks from PUMP-1.yaml, relying on inherited or default configurations.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A pump script pirouettes with newfound grace,
Web servers versioned, sensors trace the place,
WiFi whispers, firmware blooms so bright,
Platformio options fade—simpler is right! 🌟

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly summarizes the main changes: modernizing board specification, upgrading web server to v3, and removing legacy options.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch esphome-modernisation

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@TrevorSchirmer
TrevorSchirmer merged commit 64c94a4 into beta Feb 27, 2026
9 checks passed
@TrevorSchirmer
TrevorSchirmer deleted the esphome-modernisation branch February 27, 2026 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-feature New feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants