[esphome] Modernise board spec, web server v3, remove legacy options - #27
Conversation
…ions - Remove redundant esp32 board string (variant + flash_size already present) - Add web_server version: 3 to Core.yaml - Remove platformio_options board_build.flash_mode from both device YAMLs - Remove legacy BLE wifi on_connect/on_disconnect hooks from PUMP-1.yaml
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (3)
💤 Files with no reviewable changes (2)
WalkthroughThese changes modify ESPHome configuration files to enhance monitoring capabilities and simplify device-specific settings. The main Core.yaml configuration gains web server versioning, diagnostic text sensors for WiFi information and firmware version, and a reordered pump control sequence. Platform-specific compilation options and WiFi automation blocks are removed from device configurations. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
esp32: board: esp32-c6-devkitm-1string from Core.yaml (variant: esp32c6+flash_size: 8MBalready present and sufficient)version: 3toweb_server:in Core.yaml (inherited by both device variants)platformio_options: board_build.flash_mode: diofrom PUMP-1.yaml and PUMP-1_Minimal.yamlon_connect: ble.disable/on_disconnect: ble.enable) from PUMP-1.yamlTest plan
esphome configvalidates cleanly for PUMP-1.yaml and PUMP-1_Minimal.yamlType of change
Checklist
Summary by CodeRabbit
New Features
Updates