Add the Apollo Firmware Version entity - #18
Merged
Merged
Conversation
H-3 had no entity reporting which firmware it is running, and its ESPHome Version was disabled_by_default so nobody saw it. Matches the pattern already on CAST-1, AIR-1, MSR-2 and PLT-1. Both live in H-3.yaml rather than Core.yaml because H-3D has no api, no web_server and logger baud_rate 0, so text sensors there have nowhere to surface. No version bump: this rides the bump in the All Lights PR. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version: 26.8.26.1 (unchanged, see below)
What does this implement/fix?
H-3 had no entity reporting which firmware it is running, and its
ESPHome Versionwasdisabled_by_default: trueso nobody saw that either. CAST-1, AIR-1, MSR-2 and PLT-1 all already carry both.Adds
Apollo Firmware Versionand bringsESPHome Versionin line with the rest of the fleet:Published from
on_bootpriority 500, the same way CAST-1 does it:Both live in
H-3.yamlrather thanCore.yaml, which is where the fleet keeps them. H-3D has noapi:, noweb_serverandlogger: baud_rate: 0, so text sensors there have nowhere to surface and would only cost flash. H-3 already kept itsESPHome Versionin the variant file for the same reason.The block comment above the wifi_info group said "Diagnostics, all disabled by default", which stops being true once these two are visible, so it is now scoped to the Wi-Fi sensors it still describes.
No version bump. This rides the bump in the All Lights PR rather than incrementing twice in one day for a product that has not shipped. The two branches touch different parts of
H-3.yamland merge cleanly in either order.Types of changes
Checklist / Checklijst:
If user-visible functionality or configuration variables are added/modified:
esphome configpasses on both H-3.yaml and H-3D.yaml, andApollo Firmware Versionrenders in the merged H-3 config. Not yet tested on hardware.🤖 Generated with Claude Code