Skip to content

Rename esp32_improv to improv_ble - #81

Open
bharvey88 wants to merge 1 commit into
betafrom
fix/improv-ble-rename
Open

bharvey88 wants to merge 1 commit into
betafrom
fix/improv-ble-rename

Conversation

@bharvey88

Copy link
Copy Markdown
Contributor

Version: 26.9.17.2

What does this implement/fix?

esphome/esphome#19264 renamed the esp32_improv component to improv_ble and decoupled it from the ESP32 platform. The old top-level key still resolves through an alias, but every build now logs:

WARNING The 'esp32_improv:' top-level key is deprecated; rename it to 'improv_ble:'. Removed in 2027.4.0.

This renames the key and its id. I checked what else changed in #19264, since the title also says "decouple from ESP32":

  • Every YAML option is unchanged: id, authorizer, status_indicator, identify_duration, authorized_duration, wifi_timeout, next_url and the on_provisioned / on_provisioning / on_start / on_state / on_stop triggers, with the same defaults.
  • What changed is internal: the C++ namespace, the component and trigger class names, the USE_* defines, the log tag, and the dump_config heading. None of that is reachable from this config, which has no lambdas touching the component.
  • The decoupling replaces DEPENDENCIES = ["wifi", "esp32"] with a backend table plus cv.only_on(["esp32"]). ESP32 is still the only BLE server backend, so behaviour on the CAST-1 is identical.
  • improv_serial: is unaffected. Its key, options and schema are unchanged.

min_version and CI

improv_ble is in no release tag yet. The latest release is 2026.9.0 and the rename ships in 2026.10.0, so min_version goes from 2026.8.0 to 2026.10.0.

This PR will sit with failing CI until 2026.10.0 is released. ci.yml runs the stable and beta legs only, and both are on versions older than 2026.10.0, so both fail the min_version check. The beta leg will go green as soon as 2026.10.0b1 is published, the stable leg once 2026.10.0 lands. Same pattern as AIR-1 #124. Validated locally against an ESPHome dev checkout: INFO Configuration is valid! with no deprecation warning.

The min_version bump is not a breaking change for users. It only affects people compiling this YAML themselves; precompiled and OTA users are unaffected.

Types of changes

  • Bugfix (fixed change that fixes an issue)
  • New feature (thanks!)
  • Breaking change (repair/feature that breaks existing functionality)
  • Dependency Update - Does not publish
  • Other - Does not publish
  • Website of github readme file update - Does not publish
  • Github workflows - Does not publish

Checklist / Checklijst:

  • The code change has been tested and works locally
  • The code change has not yet been tested

If user-visible functionality or configuration variables are added/modified:

  • Added/updated documentation for the web page

🤖 Generated with Claude Code

esphome/esphome#19264 renamed the esp32_improv component to improv_ble
and decoupled it from the ESP32 platform. The old top-level key still
works through an alias, but every build now logs:

  The 'esp32_improv:' top-level key is deprecated; rename it to
  'improv_ble:'. Removed in 2027.4.0.

Only the key and the internal C++ names changed. Every option this
config uses (id, authorizer) is unchanged, as are identify_duration,
authorized_duration, wifi_timeout, status_indicator, next_url and the
on_* triggers. improv_serial keeps its own key and options.

improv_ble is not in any release tag yet, so min_version goes to
2026.10.0. That only affects people compiling the YAML themselves;
precompiled and OTA users are unaffected.

Version: 26.9.17.2

🤖 Generated with [Claude Code](https://claude.com/claude-code)
@bharvey88 bharvey88 added the bugfix Something isn't working label Sep 17, 2026
@coderabbitai

coderabbitai Bot commented Sep 17, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 59 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 55ef5664-6fb3-43a9-81f3-138b59f6f827

📥 Commits

Reviewing files that changed from the base of the PR and between 0b34fb2 and 1bb2363.

📒 Files selected for processing (1)
  • Integrations/ESPHome/Core.yaml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

bharvey88 added a commit that referenced this pull request Sep 18, 2026
The CAST-1 flash runs on the generic driver, so the vendor drivers linked
beside it never run but keep their code in IRAM. flash_chip: generic
drops them, freeing about 5KB of internal RAM (4,784 B measured at
runtime). Needs ESPHome 2026.10.0; the min_version bump is in #81.

🤖 Generated with [Claude Code](https://claude.com/claude-code)
@bharvey88 bharvey88 mentioned this pull request Sep 18, 2026
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant