-
Notifications
You must be signed in to change notification settings - Fork 5
Update Beta #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Update Beta #73
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
546e0c5
Merge pull request #69 from ApolloAutomation/beta
TrevorSchirmer cfa2c83
Unify WiFi + Ethernet into one firmware with automatic switchover
Bunton33 240541f
Keep WiFi connected alongside Ethernet (dual-home) so HA never loses …
Bunton33 d221ff0
Fix HAT-less crash loop, hotspot race, and WiFi-release ratchet
Bunton33 6fb62a7
Reboot once when Ethernet must kill a live hotspot (AP relaunch latch)
Bunton33 017bb63
Add Network Connection sensor for troubleshooting and notifications
Bunton33 9254392
Retire the WiFi/Ethernet firmware variants; converge the fleet on can…
Bunton33 5726c0a
Fully remove the legacy WiFi/Ethernet firmware paths (pre-launch clea…
Bunton33 9fc5ce0
Make the release-path comments match observed behavior (review round 3)
Bunton33 81a578b
Merge pull request #72 from ApolloAutomation/Add-wifi-and-ethernet
Bunton33 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| # Apollo CAST-1 — unified firmware with WiFi + Ethernet in one image. | ||
| # Ethernet is preferred when plugged in; WiFi (and its provisioning hotspot) | ||
| # takes over automatically when it is not. See Core.yaml for all device config. | ||
|
|
||
| esphome: | ||
| name: "apollo-cast-1" | ||
| project: | ||
| name: "ApolloAutomation.CAST-1" | ||
| version: ${version} | ||
|
|
||
| dashboard_import: | ||
| package_import_url: github://ApolloAutomation/CAST-1/Integrations/ESPHome/CAST-1.yaml | ||
| import_full_config: false | ||
|
|
||
| packages: | ||
| core: !include Core.yaml |
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win
🔎 Supported by static analysis
🏁 Script executed:
Repository: ApolloAutomation/CAST-1
Length of output: 4881
🌐 Web query:
GitHub CLI gh release upload --clobber behavior existing asset delete before upload official documentation💡 Result:
When using the --clobber flag with the GitHub CLI command gh release upload, existing assets with the same name are deleted before the new assets are uploaded [1][2]. This operation is not atomic, meaning that if the upload process fails or is interrupted after the deletion but before the new asset is successfully uploaded, the original asset will be lost [1][3]. Official documentation explicitly warns of this behavior to clarify that --clobber does not perform an atomic replacement, but rather a delete-then-upload sequence [1][3]. Users should be aware that this can lead to data loss if the network or process is unstable [1][3]. Additionally, in some cases involving special characters (such as spaces in filenames), the identification of existing assets may not match what is stored on the platform, which can sometimes cause the --clobber flag to fail to target the intended file [4].
Citations:
Upload all
.binassets beforemanifest.json.The workflow publishes the rewritten manifest before its referenced binaries. Clients can therefore receive new metadata while binaries are missing or stale. Because
--clobberuses delete-then-upload replacement, use versioned asset names and publish the manifest only after every referenced asset exists.🤖 Prompt for AI Agents