Skip to content

Fix/584 585 589 590 lifecycle hooks - #654

Merged
0xNgoo merged 7 commits into
Anchor-kit:mainfrom
shayam137-glitch:fix/584-585-589-590-lifecycle-hooks
Sep 30, 2026
Merged

0xNgoo merged 7 commits into
Anchor-kit:mainfrom
shayam137-glitch:fix/584-585-589-590-lifecycle-hooks

Conversation

@shayam137-glitch

Copy link
Copy Markdown
Contributor

What does this PR do?

This PR makes background startup and watcher shutdown recoverable, and invokes the declared deposit and SEP-10 challenge plugin hooks.

  • Stops the queue and earlier watchers after a later startup failure while preserving the original error.
  • Coordinates watcher start/stop races and tolerates in-flight tick failures during shutdown.
  • Runs deposit and challenge hooks in registration order with typed context; hook failures prevent persistence.
  • Adds focused lifecycle and HTTP integration tests.

How to test?

  • Run bun test (434 tests pass across 45 files).
  • For focused coverage, run bun test tests/runtime/background-lifecycle.test.ts tests/runtime/transaction-watcher.unit.test.ts tests/mvp-express.integration.test.ts.

Checklist

  • My code follows the code style of this project.
  • I have added tests for my changes.
  • I have updated the hook contract documentation.
  • I have run bun run test locally.
  • I have run bun run lint locally.

Issue Reference

Closes #584
Closes #585
Closes #589
Closes #590

@drips-wave

drips-wave Bot commented Sep 29, 2026

Copy link
Copy Markdown

@shayam137-glitch Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@0xNgoo
0xNgoo merged commit 38516a2 into Anchor-kit:main Sep 30, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

4 participants