Skip to content

(fix) clear delayed review annotations on first load - #3

Merged
Ammaar-Alam merged 3 commits into
mainfrom
agent/0.2.1-delayed-annotations
Jul 27, 2026
Merged

(fix) clear delayed review annotations on first load#3
Ammaar-Alam merged 3 commits into
mainfrom
agent/0.2.1-delayed-annotations

Conversation

@Ammaar-Alam

Copy link
Copy Markdown
Owner

What changed

  • keeps the per-question annotation baseline open while AAMC hydrates or replays saved highlights and cross-outs
  • seals the initial question when Fresh Attempt starts or resumes
  • keeps navigated questions in the capture phase until the reader's first interaction
  • preserves highlights and cross-outs created after Fresh Attempt begins, including same-range edits made while clearing is disabled
  • bumps MKit to 0.2.1 and documents the fix

Root cause

MKit froze its baseline on the first DOM scan. AAMC can hydrate annotations after that scan, so late carriers looked like new reader annotations. Replayed classes on already-masked carriers were also interpreted as reader actions. Toggling the setting Off and On happened to rebuild the baseline after hydration.

The adapter now models annotation hydration explicitly. It records and remasks startup mutations until a safe user-interaction boundary, then preserves subsequent reader-authored annotations.

Verification

  • pnpm check
    • 136 unit tests passed
    • 54 Chrome tests passed
    • lint, typecheck, build, and release audit passed
  • focused annotation suite: 47 unit tests passed
  • focused Chrome regressions: 2 passed
  • pnpm package
  • pnpm audit:release
  • unzip -t release/mkit-0.2.1.zip

PR written by Codex

@Ammaar-Alam
Ammaar-Alam marked this pull request as ready for review July 27, 2026 07:25

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4aa7058c80

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/core/review-controller.ts
Comment thread src/adapter/AamcFullLengthReviewAdapter.ts
@Ammaar-Alam

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7ea4fab9c1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/adapter/AamcFullLengthReviewAdapter.ts
@Ammaar-Alam

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Hooray!

Reviewed commit: 59ea4d24c7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Ammaar-Alam
Ammaar-Alam merged commit 99ab6eb into main Jul 27, 2026
1 check passed
@Ammaar-Alam
Ammaar-Alam deleted the agent/0.2.1-delayed-annotations branch July 27, 2026 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant