Repository navigation
Reject impossible whole-period execution deadlines - #94
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A whole-period duty could have an execution deadline before its required period ended. Resolved or non-applicable members then appeared Waiting even though valid completion was impossible.
Reject those schedules across reachable calendar phases, including leap years and longer months, and reject impossible open occurrence windows. Keep invalid work Due or Overdue with schedule-review guidance, and prevent zero or non-applicable results from making it complete. Valid post-period execution grace and review-date snapshots keep their semantics.
A reviewed successor retains invalid retired rules and superseded occurrences as warnings, with original dates, approvals, and proof unchanged. Historical binding verifies the first committed schedule context, including same-day cutovers. The guide also explains that a legacy window-end population becomes final on its first overdue day; timely member proof does not silently reconcile the occurrence or grant extra time.
Validation: fresh independent combined code and security review; complete Node 24 validation; calendar and native successor regressions; fresh generated consumer (224 records, zero errors or warnings); both package inspections; npm audit (zero vulnerabilities); private-source scan; and real-browser valid-grace Waiting plus invalid-deadline Due states, with inspected screenshots and no browser errors.