Repository navigation
Preserve review membership when services end - #89
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Terminating a vendor with completed work in an open review occurrence failed validation because the planner retained its recorded member while validation compared only today's active inventory. Share a Git-bound population across both planner paths, live validation and cutoff reconciliation so the original member and review proof survive service closeout.
Qualifying history must belong to the same Program, rule, operating window and cutoff, and must have been committed while that window was open. Reconciliation rejects arbitrary imports, missing recorded members and unrelated IDs. New eligible inventory remains visible as pending work until the owner refreshes the occurrence; final reconciliation uses the exact cutoff review plus proven earlier members. Existing material approval and finalized-proof rules remain intact.
Validation: full Node 24 CI-equivalent suite; six focused lifecycle, cutoff, provenance and memoization regressions; browser vendor termination with unchanged occurrence bytes and clean console/network; fresh generated consumer; both package dry runs; npm audit and private-source/secret scans. Coordinated patch release: 0.20.5.
Passed checks: PR validation, main validation, and npm publication with installed README smoke. Both packages are published at 0.20.5 with matching
latesttags and provenance for the exact merged release commit.