[OGUI-1453] Add context-menu with filtering and more general actions to ILG table cells#3463
Merged
isaachilly merged 27 commits intoMay 22, 2026
Conversation
Tests added cover: - Opening and closing of context menu - Match, exclude, from, to, clear and copy buttons functionality
Basic admin refactoring, clamp menu position better (no negative coords, simplify component HTML, add error handling for clipboard.
Remove index-based menu button selectors, mock window.confirm to prevent query confirmation blocking tests, separate click actions from assertions, add clipboard error test.
graduta
requested changes
May 21, 2026
Member
graduta
left a comment
There was a problem hiding this comment.
Very nice context menu, good job!
Please see below a few comments and suggestions based on existing use and behaviour of ILG:
- I believe it would be good to display a hover pop-up when hovering that informs the user to right-click for more options
- the right click menu should also have the option to open the inspector
- match and exclude should append instead of replacing the filter. Currently Infologger for all fields except date accept:
- for one world filters: multi-search by space separation. e.g. system box can accept "ECS GUI" and will search for OR
- message filter (match/exclude) accepts searching by long messages and the OR is applied on new line separator
- if we simply "replace" rather than append, shifters will lose existing filters and we do not want that as we give them a pre-defined configuration most of the time with messages to exclude for example
- severity and label columns should also update the toggle filter buttons
Caveat: I added colours as classes at the same time and hard to add both so this commit on it's own is incomplete see next.
Caveat: Wrapped Severity and Level with context menu as was doing at the same time so commit it not complete without next.
As well as making "Clear filter" buttons be disabled when there is nothing to clear for that filter.
Additionally refactor into utils and own suite.
Right-clicking a table cell now selects the row as well as opening the context menu as it is disorienting it doing otherwise. Since the row is now already selected by the time any menu action runs, the row parameter chain was removed. Adds a test that verifies this functionality and simplifies "Open Inspector" tests.
Move context menu state and methods from Log into a dedicated model and update all calls.
Collaborator
Author
|
Changes the labels in cellContextMenu. Changes the names in the affected tests and test utils.
…ith-it' of github.com:AliceO2Group/WebUi into feature/ILG/OGUI-1453/Double-click-on-value-to-filter-with-it
…enContextMenu It used to be that in the case that two following tests clicked on cells with different field types, you could use the labels to determine if the context menu had rerendered or not. This is a janky solution and it is easier to rely just on a small timeout in the openContextMenu helper instead. Thus I am removing these helpers.
Add tests plus add utility function
graduta
requested changes
May 22, 2026
Member
graduta
left a comment
There was a problem hiding this comment.
Very nice progress! I believe there are two more issues that need addressing and then PR will be good to be shipped.
- I did not see a reply or implementation to my suggestion on hover of cell so that the users are aware of the feature
- It seems that a small bug is introduced where the separator line between the message column and one before is not there anymore (see screenshot)
Adds a hint button inside each non-empty cell as a suggestion to the user that there are menu options available.
…nings Update menu height as it was not at all correct and legacy left unchecked. Accounts for the footer/status-bar so that is always visible.
Add context menu hint tests covering rendering, click behaviour and hover visibility. Refactor filled and empty row adding.
graduta
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have JIRA issue created