[PWGDQ] make matching QA table filling more flexible#16325
Open
aferrero2707 wants to merge 1 commit into
Open
Conversation
aferrero2707
requested review from
alibuild,
iarsene,
lucamicheletti93 and
mcoquet642
as code owners
|
O2 linter results: ❌ 0 errors, |
aferrero2707
force-pushed
the
PWGDQ-matching-qa-move-tree-filling
branch
from
ae1ffb8 to
80e504c
Compare
Instead of using an hard-coded list of matching methods and corresponding indexes when filling the derived tables, the filling is done using a dynamic list of methods and correspoding indexes that is based on what is actually requested in the configuration. The horizontal bin labels of a dedicated TH1 histogram provide the correspondance between method labels and their indexes, to be used when reading back the derived tables to generate final histograms. An "isTagged" column is also added to the derived MCH table to flag the tracks that have good quality and cross the active area of the MFT, and therefore are expected to have a matchable MFT track. The tagging does not rely on MC truth, and can therefore be also applied to real data.
aferrero2707
force-pushed
the
PWGDQ-matching-qa-move-tree-filling
branch
from
80e504c to
43f229d
Compare
Contributor
Author
|
@mcoquet642 this is now ready for review, could you please have a look? Thanks! |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of using an hard-coded list of matching methods and corresponding indexes when filling the derived tables, the filling is done using a dynamic list of methods and corresponding indexes that is based on what is actually requested in the configuration.
The horizontal bin labels of a dedicated TH1 histogram provide the correspondence between method labels and their indexes, to be used when reading back the derived tables to generate final histograms.
An
isTaggedcolumn is also added to the derived MCH table to flag the tracks that have good quality and cross the active area of the MFT, and therefore are expected to have a matchable MFT track. The tagging does not rely on MC truth, and can therefore be also applied to real data.