Skip to content

fix: sanitize shell/subprocess call in o2_dpg_workflow_runner.py #2362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
orbisai0security wants to merge 1 commit into from
+4 −2
Closed

fix: sanitize shell/subprocess call in o2_dpg_workflow_runner.py #2362

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions MC/bin/o2_dpg_workflow_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,8 +110,10 @@ def setup_logger(name, log_file, level=logging.INFO):
# TODO: integrate into standard logger
def send_webhook(hook, t):
if hook!=None:
command="curl -X POST -H 'Content-type: application/json' --data '{\"text\":\" " + str(t) + "\"}' " + str(hook) + " &> /dev/null"
os.system(command)
import json
data = json.dumps({"text": " " + str(t)})
subprocess.run(["curl", "-X", "POST", "-H", "Content-type: application/json", "--data", data, str(hook)],
stdout=subprocess.DEVNULL, stderr=subprocess.DEVNULL)

# A fallback solution to getting all child procs
# in case psutil has problems (PermissionError).
Expand Down