Repository navigation
fix(data-ngin): fail the DAG run when the pipeline task fails - #18
Merged
Merged
Conversation
Each DAG ended in a staleness_check task with trigger_rule=all_done. Airflow takes a run's state from its leaf tasks, so after run_pipeline failed the always-run leaf succeeded and the run was marked success. A manual run on the box hit exactly this: 2 of 29 Databento symbols failed, and the run showed green. Drop the warn-only task. The old production DAGs never had it, and the daily data_ngin.ops.check_data_freshness cron job covers it. A test now keeps all_done out of the DAG files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each data-ngin DAG ended in a
staleness_checktask withtrigger_rule="all_done". Airflow sets a run's state from its leaf tasks, so whenrun_pipelinefailed, that always-run leaf still succeeded and the whole run showed success.Found by a manual cutover-check run on the algocloud box: 2 of 29 Databento symbols failed with
504 The remote gateway timed out, the pipeline task failed, and the run still showed green.check_data_freshnesscron job covers it.pipeline_tasks.check_staleness.all_doneout of the DAG files.Tests, ruff and mypy are clean.