Repository navigation
[F1/F2] Position override UI — write to the qt stream with mandatory audit fields #26
Description
Concept
AlgoLens becomes the interface QT uses to create/edit positions, replacing hand-editing the database.
Architecturally this is just another DB writer — per ADR-000 INV-1, all inter-service communication goes through TimescaleDB, so no new RPC path is needed. AlgoLens writes rows; trade-ngin's risk gate validates them.
What the UI must do
- Show the
systemvsqtportfolios side by side (that split is F1 — trade-ngin#47) - Let QT edit only the
qtstream - Capture a required, non-empty
reasonon every edit — the ADR-000 C-5trading.position_overridesaudit table makes this non-negotiable, so the UI cannot allow a blank submit - Surface the risk-gate result (
risk_check_result) back to the user, including the breach case
Depends on
- trade-ngin#47 (F1) — the
portfolio_typeschema must exist first - trade-ngin#48 (F2) — the risk-validation stage and
position_overridestable - DECISION-1 (still open): hard-block vs audited-override determines whether the UI needs an explicit "override anyway" affordance at all
Note
Per ADR-000 C-3, AlgoLens' backend is permitted to write trading.position_overrides (inserts only) — this is the one carve-out from trade-ngin's ownership of the trading schema.
Refs: FEATURE_ANALYSIS_TRADE_NGIN_DATA_NGIN.md F1/F2, adr/ADR-000-cross-repo-contracts.md C-3/C-5, adr/ADR-003-algolens.md.
Activity
jrile018 commentedon Jul 26, 2026
Status: implemented — PR #31 (API, gate, audit) and PR #32 (UI). Not merged.
Companion to trade-ngin#48. Full detail is there; this is the AlgoLens side.
What exists now
POST /portfolio/positions— writes theqtrow and its audit row in one transaction. If the audit insert fails, the position change rolls back with it.GET /portfolio/overrides/<strategy_id>— the audit trail.Mandatory audit fields, as this issue requires
reasonis required and non-empty (rejected in the API before it reaches the DB CHECK, so the user gets a useful message rather than an IntegrityError),source_appis stampedalgolens, anduser_idcomes from the JWT. Verified against a real PostgreSQL: an unqualifiedUPDATE ... SET reason='TAMPERED'andDELETE FROM trading.position_overridesboth left the data intact.Writes to the qt stream only
systemandbenchmarkare refused outright — supplyingportfolio_typeat all is a 400. They are the baseline QT's discretionary alpha is measured against, and a baseline you can edit measures nothing.Three bugs caught in review worth recording
No authorization. The endpoints originally had
@jwt_required()only, which proves who you are, not that you may do this. Per ADR-000 C-6 thesubscriber_*roles are external paying customers — any of them could have rewritten the fund's book. There is now a default-deny role gate; verified subscribers get 403 and write nothing. See #27.The post-save refresh did not refresh. It navigated "back" to force a reload, but
Dashboardfetches with an empty dependency array and never unmounts. The edit would not have appeared — reading exactly like a failed save, on a book where the natural response is to make the edit again.The modal had no React
key, so form state survived across positions. A reason typed for ES could be written into NQ's append-only audit row, which by design cannot be corrected afterwards.Dependency
Requires trade-ngin migrations 001–004 (trade-ngin#54, #55) before it can run. The gate reports
evaluated: falseuntil trade-ngin#56 publishes the risk envelope — honest about not checking, rather than reporting a pass.raohemdutt commentedon Oct 6, 2026
Status: Under review
Waiting on: The QT platform review
Next step: Dom: review
Notes: Part of the QT platform, which is under review by Dom.
raohemdutt commentedon Oct 16, 2026
Done on main by AlgoLens #103, #108 and #109: the desk sees the model's book, its request and the final book, edits only its request with a required reason, and sees the engine's result and risk check (#133).