Repository navigation
Keep workouts running offline and fill metrics after strap sync - #24
Closed
AlexSchmidt1999 wants to merge 5 commits into
Closed
AlexSchmidt1999 wants to merge 5 commits into
AlexSchmidt1999 wants to merge 5 commits into
Conversation
…codex/offline-training
Owner
Author
|
Closing this older fork test PR. Its full head ( The relevant changes are now submitted for upstream review in #2760, #2761. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Leaving Bluetooth range must not pause an intentional workout, and a workout without live HR/GPS must remain saved for later strap history.
The shared training coordinator suspends pulse deadlines and reminders while disconnected. Reconnection grants a fresh ten-minute window without treating the connection as a pulse receipt. Existing manual pauses remain explicit; accepted unchanged pulse values still count as fresh receipts.
Normal recorded workouts now save their interval with missing metrics instead of disappearing. A local, bounded history ledger keeps recorded workouts and Lift Log eligible for successive sync chunks through the existing rescorer. Stored pause intervals are excluded from scoring. Stream fingerprints avoid repeated work, scoring runs off the main actor, failed writes remain retryable, and hand-entered metric edits remain authoritative. No database migration, dependency, network endpoint or BLE command is added. Apple integration only; analytics formulas are unchanged and Android is not modified or built.
Validation: 52 focused macOS app tests passed, including 599/600-second boundaries, disconnected restore/reconnect, empty-HR workout persistence, failed-save retry, successive chunks, active device namespaces, manual edits, paused samples through the full analysis pass, and existing Today/sync layout tests. Source policy, translation coverage, doc-comment hygiene and diff checks passed. The final unsigned iOS Release app/widgets/watch build and binary policy passed (four bundles). NOOP 12.0.0 build 448 was locally signed, installed and launched on the paired iPhone with the existing bundle identity; the installed build was verified. Install provenance is retained locally with the exact commit and executable hashes. GitHub Actions remains disabled by GitHub for this fork's Actions usage; no CI success is claimed.
The Dynamic Island and centered Today pending-sync fixes are merged into the PR base. This PR provides their combined Apple test version as build 448. The real strap out-of-range scenario still needs the owner's device test; a disconnected phone cannot determine whether the strap is worn.