Repository navigation
Keep Today sync progress from shifting the dashboard - #12
Closed
AlexSchmidt1999 wants to merge 2 commits into
Closed
AlexSchmidt1999 wants to merge 2 commits into
AlexSchmidt1999 wants to merge 2 commits into
Conversation
Owner
Author
|
Closing this older fork test PR. Its full head ( The relevant changes are now submitted for upstream review in #2756. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Today could insert and remove a syncing/chunk note as each history slice starts or finishes, moving the content near the scores. Classic Today now keeps progress in its existing header and persistent Data Sources row. Liquid Today keeps its history row present before the first completed sync. Both detailed rows reuse the existing delayed sync-end signal and chunk copy; progress stays on one line while sync errors retain their explanation.
This is an Apple UI change. Strap synchronization, scoring, storage and the manual pull-to-refresh action are unchanged. iOS build 438 combines this follow-up with the existing training widget work for local testing. Stacked on the widgets branch; no upstream PR or merge is requested.
Validation: macOS app compiled and 20 targeted snapshot/sync tests passed; iOS Release app, widgets and watch targets compiled. Translation, doc-comment, source policy and four-bundle unsigned binary analysis passed. The separate baseline commit changes only the reviewed project build-counter hash. Widget layout renders still pass the existing size checks.
NOOP 12.0.0 build 438 was verified installed and launched over Wi-Fi with the existing bundle ID. The subsequent combined test build 439, including the widget alignment follow-up in #13, is now verified installed and launched. The idle disconnected device tunnel established successfully when installation was requested. A longer WHOOP sync on iPhone, in both Today styles and while scrolling, is still needed to confirm that the intermittent visible hitch is gone. The local installation monitor remains paused.