feat: parse workbook properties (core + extended) - #2
Draft
Alex-ley-scrub wants to merge 8 commits into
Draft
Conversation
Adds WorkbookProperties to Metadata, exposing XLSX docProps/core.xml and docProps/app.xml fields such as creator, last_modified_by, application, company, etc. Closes tafia#677
read_workbook's record loop left unmatched workbook-global records unconsumed, so the next read_type() call would misread the leftover body as the next record id. Depending on the body size this either dropped every sheet silently or panicked while decoding BrtBundleSh from an empty buffer. Consume the body of any unhandled record via fill_buffer, same as the other matched arms already do. Fixes tafia#666
- Close the unclosed delimiter in test_xlsx_workbook_properties_missing. - Add blank lines between WorkbookProperties fields for readability. - Rename PropField to DocProperty.
Reuses the existing XLSX property parsers (now pub(crate)) since XLSB uses the same OPC XML package layout for document properties.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the base PR for a local stacked PR chain in this fork.
Canonical upstream review PR:
This fork-local PR exists so GitHub can model the stacked PR relationship for follow-up work based on
feat/677-workbook-properties, such as:The actual maintainer-facing review remains on the upstream PR linked above.