ci: make the ruby 4.0 build required - #4137
Merged
Merged
Conversation
Ruby 4.0 has proven stable against the suite, so its matrix leg no longer needs to be allowed to fail. It was the only leg using experimental, which also made continue-on-error inert, so both are removed. A Ruby 4.0 regression now blocks the build instead of passing silently.
tvdeyen
force-pushed
the
ci-ruby-4-required
branch
from
August 7, 2026 10:00
3352035 to
b53d0cc
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4137 +/- ##
=======================================
Coverage 98.27% 98.27%
=======================================
Files 351 351
Lines 9239 9239
=======================================
Hits 9080 9080
Misses 159 159
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
The Rails 8.0 / Ruby 4.0 matrix leg was marked
experimental: true, so it ran withcontinue-on-errorand a failure there passed the build silently. Ruby 4.0 has proven stable against the suite, so this promotes that leg to a required build — a Ruby 4.0 regression now blocks instead of going unnoticed.It was the only leg using
experimental, which leftcontinue-on-error: ${{ matrix.experimental == true }}referencing an undefined key (always false), so both are removed together rather than leaving dead config. If an experimental leg is needed again later, re-addingexperimental: trueplus thecontinue-on-errorline restores the mechanism.This is independent of the Codecov upload changes — the Ruby 4.0 leg does not upload coverage (that step is gated to
ruby == '3.4'), so nothing here affects coverage reporting.Notable changes (remove if none)
A Ruby 4.0 test failure will now fail CI and block merges, where previously it was tolerated.
Checklist