[Aikido] Fix 23 security issues in concurrent-ruby, nokogiri, net-imap and 3 more#309
Open
aikido-autofix[bot] wants to merge 1 commit into
Open
[Aikido] Fix 23 security issues in concurrent-ruby, nokogiri, net-imap and 3 more#309aikido-autofix[bot] wants to merge 1 commit into
aikido-autofix[bot] wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade concurrent-ruby, nokogiri, net-imap, sqlite3, websocket-driver, and psych to fix DoS vulnerabilities including infinite retry loops, lock state corruption, and memory leaks.
✅ 23 CVEs resolved by this upgrade
This PR will resolve the following CVEs:
AtomicReference#updateenters an infinite busy loop when the stored value isFloat::NANdue to NaN's self-inequality, causing CPU exhaustion and permanent hangs in applications storing numeric data.release_write_lockfails to verify the calling thread owns the lock, allowing any thread to release it and enable concurrent writers;release_read_lockunconditionally decrements the counter, corrupting the lock state and causing subsequent read acquisitions to fail with ResourceLimitError.ReentrantReadWriteLock's per-thread hold counter allows a write lock to be incorrectly granted after 32,768 reentrant read acquisitions, breaking mutual exclusion and enabling concurrent read access during claimed write lock ownership. This can lead to data races and inconsistent reads of protected state.canonicalizemethods returns empty string instead of raising an exception, allowing downstream libraries to accept invalid XML and bypass signature validation in SAML implementations.do_xincludefreed memory containing nodes and namespaces already exposed to Ruby, causing use-after-free vulnerabilities. This could result in invalid memory reads or writes when using the freed objects..allocate()and cannot be triggered through normal API usage or untrusted input.Document#root=, potentially causing invalid memory reads or segfaults during garbage collection. The vulnerability requires programming error and cannot be triggered by untrusted input.#idand#enablecommands fail to validate arguments, allowing attackers to inject arbitrary IMAP commands via CRLF sequences. This could enable unauthorized mailbox operations when untrusted input is passed to these commands.{0}or{0+}) into search, sort, fetch, and thread commands, causing command absorption and denial of service through hangs and timeouts. Multi-threaded environments are particularly vulnerable as subsequent commands may hang indefinitely waiting for responses.create_functionordefine_function.🔗 Related Tasks