Fix: align pitch and yaw return order between model and pipeline - #46
Open
MCHieu-17 wants to merge 2 commits into
Open
Fix: align pitch and yaw return order between model and pipeline#46MCHieu-17 wants to merge 2 commits into
MCHieu-17 wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request fixes an output-order mismatch in the gaze model by making l2cs/model.py return (pitch, yaw) in the same order expected by the pipeline and downstream consumers (e.g., gaze rendering).
Changes:
- Swapped the return order in
L2CSmodelforward()from(yaw, pitch)to(pitch, yaw).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+68
to
+70
| pre_yaw_gaze = self.fc_yaw_gaze(x) | ||
| pre_pitch_gaze = self.fc_pitch_gaze(x) | ||
| return pre_yaw_gaze, pre_pitch_gaze | ||
| return pre_pitch_gaze, pre_yaw_gaze |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #45
Changes Made
pitchandyawto be consistent betweenl2cs/model.pyandl2cs/pipeline.py.