fix(frontend): show correct variant name in commit modal for new vari…#4694
Conversation
|
✅ Thanks @Sanket2329! This PR now meets the contribution requirements and has been reopened. A maintainer will review it soon. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (6)
📝 WalkthroughSummary by CodeRabbit
WalkthroughA new derived Jotai atom ChangesCommit Modal Original Entity Name
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@Sanket2329 is attempting to deploy a commit to the agenta projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Hi @mmabrouk! Could you please review this PR when you have a moment? Let me know if there are any changes or improvements you'd like me to make to it! Thank you! |
|
Thanks for the PR @Sanket2329 I have assigned @ardaerzin for the review. |
Summary
commitModalOriginalEntityNameAtominstate.tsto keep track of the original name of the entity before any user edit overrides.EntityCommitTitle.tsxto conditionally displayoriginalEntityNamefor commit actions.EntityCommitContent.tsxto displayoriginalEntityNameas the source, and the user-typedentityNameas the target (blue text) in the version transition display.Testing
Verified locally
http://localhost:3000by editing a prompt template on thedefaultvariant, choosing the "As a new variant" option in the commit modal, and typing in a new variant name. The title, description text, and version transition correctly showdefaultas the source instead of the new target variant name.pnpm lint-fixon thewebworkspace to check formatting.@agenta/entity-uiand@agenta/oss.Added or updated tests
N/A
QA follow-up
N/A
Demo
Screen.Recording.2026-06-14.at.12.11.48.PM.1.mp4
Checklist