chore(api): Drop legacy app-centric tables and dead model classes

[jp-agenta]

Context

The pre-project app ecosystem (apps/variants/bases, deployments, docker images, templates, old environments, old testsets, the old auto- and human-evaluation tables, and the Mongo-migration artifact ids_mapping) is dead code: its routers were deleted, its data was migrated to the new entities earlier in both migration chains, and the model classes were referenced only by an unimported re-export shim and unimported converters. EE also carries legacy nullable organization_id/workspace_id columns (plus deployments.cloud_map_service_id and auto_evaluator_configs.app_id) exclusively on these tables, so dropping them is the schema-parity fix for that drift. This is sequencing step 5 / parity step 2 of docs/designs/oss-ee-convergence/assessment-a-oss-multi-org.md.

Changes

Two migrations, one per chain (the chains are independent), each running DROP TABLE IF EXISTS … CASCADE over the same 20 tables, children before parents: human_evaluation_variants, human_evaluations_scenarios, human_evaluations, auto_evaluation_scenario_results, auto_evaluation_aggregated_results, auto_evaluation_evaluator_configs, auto_evaluation_scenarios, auto_evaluations, auto_evaluator_configs, environments_revisions, environments, app_variant_revisions, app_variants, bases, deployments, docker_images, templates, app_db, testsets, ids_mapping. Downgrade raises (irreversible; restore from backup). The migrations also drop the four enum types the table drops orphan (app_type_enum, templatetype, and nodetype/treetype, which the earlier nodes drop had already left behind); no live column or code uses them. The tracing chains get the same treatment: a new revision f3a4b5c6d7e8 in both editions drops nodetype/treetype there too (orphaned by the earlier nodes drop; spans uses spantype/tracetype/otelspankind/otelstatuscode, which stay).

Code cleanup in the same PR:

• The 15 dead classes are deleted from oss/src/models/db_models.py (AppDB, DeploymentDB, VariantBaseDB, AppVariantDB, AppVariantRevisionsDB, AppEnvironmentDB, AppEnvironmentRevisionDB, TestsetDB, EvaluatorConfigDB, IDsMappingDB, and the five old Evaluation* classes), along with their now-unused imports.
• oss/src/models/db/models.py (re-export shim) and oss/src/models/converters.py had zero importers; both files are deleted.
• db_manager_ee.create_deployment had no callers; deleted with its DeploymentDB import.
• deprecated_models.py / deprecated_transfer_models.py stay: historical data migrations import them, and deleting them would break replaying old chains.
• Historical migrations that still imported the deleted classes directly (create_free_plans imported AppDB; the evaluators, environments, applications_workflow, and projects data migrations imported the others) now import frozen copies of the final pre-drop shapes, added to deprecated_models.py on a dedicated DroppedBase. Alembic loads every version script at startup, so without this the migration runner fails to boot on ImportError.

Not dropped: the new-architecture tables with similar names (evaluation_scenarios, testset_artifacts, environment_*) are untouched; the old/new names differ (auto_evaluations vs evaluation_runs, testsets vs testset_artifacts).

Lifecycle/FK standardization (per docs/designs/oss-ee-convergence/db-integrity-audit.md, migrations 4f5a6b7c8d9e OSS / 5a6b7c8d9e0f EE / a4b5c6d7e8f9 both tracing chains): every table gets the six lifecycle columns, fully nullable, created_at with a server default; lifecycle actor FKs are dropped (organizations x3, api_keys, webhook_subscriptions); owning-scope FKs added (webhook_deliveries to projects + subscriptions, secrets to projects/organizations, subscriptions to organizations, meters retargeted from subscriptions to organizations, all CASCADE); membership user FKs get the CASCADE the models declared; invitation user FK becomes SET NULL. The LegacyLifecycleDBA mixin is retired and models now agree with the database everywhere. New convention unit tests (oss/tests/pytest/unit/models/test_lifecycle_conventions.py and the EE counterpart) enforce the standard.

Tests / notes

• ruff format and ruff check pass; all 175 alembic version scripts across both chains verified to import cleanly (this is what the migration runner does on boot); no remaining references to the dropped classes outside the frozen scaffolding (legacy oss/tests/legacy/old_tests are not collected per pytest.ini testpaths).
• EE cloud must archive these 20 tables before this merges (pre-drop verification per the assessment); OSS deployments got their data migrated by earlier revisions in the chain.
• Stacked on the convergence stack so each chain's migration extends the step-1 parity revisions linearly (a parallel branch would create two alembic heads).

🤖 Generated with Claude Code

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
agenta-documentation	Ready	Preview, Comment	Jun 14, 2026 6:40pm

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 311064fb-b43d-4eb6-8ec7-5f37b6375fde

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch chore/drop-legacy-tables

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

Railway Preview Environment

Preview URL	https://gateway-production-0c74.up.railway.app/w
Image tag	pr-4676-3ebefbc
Status	Failed
Railway logs	Open logs
Logs	View workflow run
Updated at 2026-06-14T18:46:05.087Z