Repository navigation
ci: cap release-please search depth - #421
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The workflow bypasses this configuration file, so CI will not apply the new search limits.
1 open issue
What changed in this PR
This PR limits Release Please’s history searches to avoid the GraphQL failure encountered while locating the v3.6.1 release PR.
Changes:
- Sets
release-search-depthandcommit-search-depthto 60. - Preserves the existing release type and last-release SHA.
| File | Description |
|---|---|
| release-please-config.json | Adds limits for release and commit history searches. |
Review effort: Balanced
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Please fails with a GitHub GraphQL error while paging back through merge commits looking for the v3.6.1 release PR, whose merge commit is no longer in main's history. Capping release-search-depth and commit-search-depth at 60 stops the lookup before it reaches the failing part of history.
Dry run against this branch (
release-please release-pr --dry-run) finds release v3.6.1 at 95018f7 and builds the release PR without error.