Repository navigation
fix(macos): restore the fullscreen chrome fixes lost from closed PR 243 - #283
Merged
Merged
Conversation
Problem: PR 243 was closed as superseded by #255, which re-applied only its quit and upgrade restore protection. The fullscreen fixes developed on the same branch never reached main, although the installed production app was built from it (5cf109d). Builds from main again showed the traffic lights in a separate empty native titlebar row in fullscreen, and lacked the other fullscreen corrections. Decision: take the branch's final vendored GPUI macOS window layer (window.rs, events.rs, gpui_macos.rs) and its gpui-modifications.json record. Main has not changed these files since the branch point, so this is exactly the branch's fullscreen work: suppress the empty native fullscreen titlebar (1f9b7d9), keep tabs clear of the revealed system menu (104c712), follow the fullscreen toolbar layout and convert input through the renderer view (1d40419), anchor native controls and accessibility to the renderer view (c91c282), avoid fullscreen crashes on borderless auxiliary windows (a553487), mark KVO key-path access unsafe (29f4c24). The restore changes of that branch stay as #255 implemented them; its native acceptance fixtures and the separate production rebuild command are not part of this change. Rationale: the fixes are self-contained in the vendored platform layer, so carrying the files over restores them without touching the restore logic main already owns. Validation: an optimized Chau7 Next bundle built from this tree passed the packaging vendor-hash verification and code signature checks. CI runs the workspace tests on macOS, Linux and Windows. Fullscreen visual acceptance on a display is still to be confirmed by the user. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restores the macOS fullscreen fixes that were developed on PR #243 but never reached
main.Why
#243 was closed as superseded by #255, which re-applied only its quit/upgrade restore protection. The fullscreen work on the same branch was left behind, while the installed production app was built from that branch (
5cf109dd). Builds frommaintherefore regressed: in fullscreen the traffic lights sat in a separate empty native titlebar row above the tabs (reported on the current Chau7 Next test build).What
The branch's final vendored GPUI macOS window layer (
vendor/gpui-pre-macos/src/window.rs,events.rs,gpui_macos.rs) and itsvendor/gpui-modifications.jsonrecord.mainhas not changed these files since the branch point, so this is exactly the branch's fullscreen work:1f9b7d98)104c712e)1d404191)c91c282c)a5534870)29f4c24b)Not included: #243's restore changes (kept as #255 implemented them), its native acceptance fixtures, and the separate
chau7-rebuildcommand.Validation
🤖 Generated with Claude Code