Repository navigation
Unclip bottom buttons, campus-time availability, Trending fallback - #40
Merged
Merged
Conversation
iOS: the custom tab bar floats over tab content, and its safe-area clearance doesn't reach the NavigationStacks inside each tab, so Filter's Apply button and Favorites' Save & Continue sat half under the bar. Both now add CustomTabBar.clearance themselves. API: Trending needs 2+ favorites in 30 days, which nothing meets between semesters. When fewer than 5 dishes qualify, fall back to the past year. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
_today_str() used the server clock, which is UTC on Elastic Beanstalk. From 8 PM Eastern the API treated tomorrow as today, so during dinner food pages showed "Unavailable" for dishes being served and search's available-today ordering was wrong. Use America/New_York; add tzdata so the zone is always resolvable. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
AdvayMonga
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
iOS — buttons hidden under the tab bar
Filter's Apply button and Favorites' Save & Continue were half covered by the custom tab bar. The bar floats over tab content and its safe-area clearance doesn't reach the
NavigationStacks inside each tab. Both views now addCustomTabBar.clearancethemselves (they are only ever shown inside the tab UI). Verified with simulator screenshots before/after.API — "today" was UTC
_today_str()used the server clock (UTC on Elastic Beanstalk). From 8 PM Eastern the API treated tomorrow as today, so during dinner food pages showed Unavailable this week for dishes being served right then, and search's available-today ordering was off. Now usesAmerica/New_York(plustzdataso the zone always resolves).API — Trending was always empty
Trending requires 2+ favorites within 30 days; right now no dish meets that, so the tag and the "Trending foods" list on the empty-search screen never appeared. It now uses the last 30 days when at least 5 dishes qualify, and otherwise falls back to the past year (19 dishes today, 16 on current menus).
Merging deploys the API.
🤖 Generated with Claude Code