Repository navigation
UI polish: food card tap, filter fade, card outlines, launch heading - #35
Merged
Merged
Conversation
PressEffect used DragGesture(minimumDistance: 0), which recognizes on touch-down and beat the card's onTapGesture, so tapping a food no longer opened its page. Track the press with a long press that never completes instead; @GestureState releases it on lift or scroll. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The touch-down gesture fought the scroll view and the card's own tap gestures. Drop PressEffect entirely and animate from the tap handler, which leaves scrolling and both tap gestures untouched. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
AdvayMonga
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bundles the recent small UI changes into one PR. It supersedes #36 and #37, whose commits are included here.
Food card tap (the regression fix)
PressEffect— the touch-down press animation added in Align Tracker UI with home page styling #30 — is removed. Its gesture recognized on touch-down, beatingFoodItemRow's.onTapGesture, so tapping a food stopped opening its page, and it also fought the scroll view.onTap?()fires immediately, and the scale returns after 45ms. No delay before navigation, and scrolling is untouched.PressableButtonStyle(favorite, add-to-tracker, profile rows) is unchanged — those are real Buttons and always worked.Filter overlay
HomeView's ZStack, matchingSearchOverlay, instead of a sheet sliding up from the bottom.Card outlines (was #37)
homeCard(tint:thin:)gainsthin(1pt light / 1.5 dark vs 1.5 / 2). The food page's Nutrition Facts and Ingredients cards go gray + thin; profile cards go thin. The calorie hero and macro cards keep their colors.Launch heading (was #36)
Test plan
🤖 Generated with Claude Code