Repository navigation
fix: max_positions reads the text config (was 0 for Gemma 4) - #95
Merged
Merged
Conversation
…ling the scoring length check) Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CustomTorchBackend.max_positionsreadmax_position_embeddingsfrom the top-level config. Gemma 4's config is composite and keeps it only on the text config, so it was 0 — which silently disabled the prompt-length bound inscore_logprobs(prompt_logprobspath). Now readsget_text_config(); Qwen3-MoE is unaffected (its text config is itself). Suite: 485 passed.🤖 Generated with Claude Code