Skip to content

ACP2E-4907: Document DataProvider/TestWith data injection into fixtures - #189

Merged
keharper merged 2 commits into
AdobeDocs:2.4.10-releasefrom
bubasuma:ACP2E-4907
Sep 15, 2026
Merged

keharper merged 2 commits into
AdobeDocs:2.4.10-releasefrom
bubasuma:ACP2E-4907

Conversation

@bubasuma

@bubasuma bubasuma commented Sep 15, 2026 •

Copy link
Copy Markdown
Contributor

Purpose of this pull request

This pull request documents the dataset reserved fixture alias (added for ACP2E-4883), which exposes the current PHPUnit #[DataProvider]/#[TestWith] row to #[DataFixture] attributes via $dataset.key$. This lets a single parameterized test replace multiple near-identical test methods that only differ in fixture configuration.

  • Adds a "Supply DataProvider or TestWith data to a fixture" reference section to the DataFixture attribute doc
  • Adds an "Avoid duplicating tests that only differ by fixture data" best practice to the data fixtures guide

Affected pages

Links to the public Commerce codebase

@github-project-automation github-project-automation Bot moved this to 📋 Needs Review in Commerce - Pull Requests Sep 15, 2026
@bubasuma
bubasuma changed the base branch from main to 2.4.10-release September 15, 2026 16:14
@github-actions

Copy link
Copy Markdown
Contributor

🔍 Linter Report

Click to expand full report
═══════════════════════════════════════════════════════════════
                     LINTER REPORT
═══════════════════════════════════════════════════════════════

Generated: 2026-09-15T16:15:30.057Z
Mode: Full Linting (all rules + dead links check)
Target Directory: /home/runner/work/commerce-testing/commerce-testing

───────────────────────────────────────────────────────────────

Files to process: 2


═══════════════════════════════════════════════════════════════
                        SUMMARY
═══════════════════════════════════════════════════════════════

  📁 Files processed:    2
  📄 Files with issues:  0
  ❌ Total errors:       0
  ⚠️  Total warnings:     0
  📋 Total issues:       0

Result: ✅ PASSED - All files passed linting successfully!

═══════════════════════════════════════════════════════════════

This comment was automatically generated by the linter bot.

Comment thread src/pages/guide/integration/attributes/data-fixture.md Outdated
@github-project-automation github-project-automation Bot moved this from 📋 Needs Review to 👍 Approved in Commerce - Pull Requests Sep 15, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🔍 Linter Report

Click to expand full report
═══════════════════════════════════════════════════════════════
                     LINTER REPORT
═══════════════════════════════════════════════════════════════

Generated: 2026-09-15T16:38:41.071Z
Mode: Full Linting (all rules + dead links check)
Target Directory: /home/runner/work/commerce-testing/commerce-testing

───────────────────────────────────────────────────────────────

Files to process: 2


═══════════════════════════════════════════════════════════════
                        SUMMARY
═══════════════════════════════════════════════════════════════

  📁 Files processed:    2
  📄 Files with issues:  0
  ❌ Total errors:       0
  ⚠️  Total warnings:     0
  📋 Total issues:       0

Result: ✅ PASSED - All files passed linting successfully!

═══════════════════════════════════════════════════════════════

This comment was automatically generated by the linter bot.

@keharper
keharper merged commit 1d73225 into AdobeDocs:2.4.10-release Sep 15, 2026
6 checks passed
@github-project-automation github-project-automation Bot moved this from 👍 Approved to 🏁 Done in Commerce - Pull Requests Sep 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants