Repository navigation
fix(parser): keep negated Host patterns when saving - #127
Open
lord-helicon wants to merge 1 commit into
Open
lord-helicon wants to merge 1 commit into
lord-helicon wants to merge 1 commit into
Conversation
The ssh_config parser strips the leading "!" from Pattern.Str and only tracks the negation internally, so every save rewrote "Host * !foo" as "Host * foo", inverting its meaning. It also made "Host !foo" show up as a server named foo. Restore the "!" right after parsing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ssh_config parser strips the leading
!fromPattern.Strand tracks negation only internally. So every save through lazyssh rewroteHost * !fooasHost * foo, which reverses its meaning. It also madeHost !fooshow up in the server list as a server namedfoo, and adding a server calledfoowas refused as a duplicate.The
!is now restored right after parsing.Matchesstill uses the parser's internal negation, so pattern matching is unchanged.Testing
TestSaveKeepsNegatedPatternschecks thatHost !bastionandHost * !lab-? !bsurvive a save unchanged and aren't listed as servers.make build(gofumpt, vet, golangci-lint) andmake testpass.This PR is independent of my other two config fixes. The small
helpers_test.gois identical in all three, so they merge cleanly in any order.