Fix AttributeError in Wrapper.print_package_versions - #2167
Open
Sanjays2402 wants to merge 2 commits into
Open
Conversation
`rez-tool ++versions` crashed with:
AttributeError: Package instance has no attribute 'path'
`print_package_versions` builds its output rows from `pkg.path`, but
`Package` has no `path` attribute; the filesystem location of a package
is exposed as `uri` (as used by rez-view, rez-help and rez-cp). Any use
of `++versions` on a suite tool therefore raised instead of printing the
version table.
Use `pkg.uri` and add a regression test that runs
`Wrapper.print_package_versions` against a saved suite.
|
Contributor
|
Hello, thanks for the PR submission. We'd like to see CLA's signed before reviewing if possible, because if the CLA is unable to be signed, we are unable to accept the contribution. Hope you understand. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2046
print_package_versionsbuilds its rows frompkg.path, butPackagehas nopathattribute — the package's location is exposed asuri(as rez-view, rez-help and rez-cp already use), so++versionson any suite tool raisedAttributeError: Package instance has no attribute 'path'instead of printing the table.Added
test_print_package_versions, which fails with the reported AttributeError before the change and passes after.