test: add unit tests for rez.utils.base26

[darrenhuai]

rez.utils.base26 had no tests at all - get_next_base26 (the letter-increment logic for variant shortlink IDs) and create_unique_base26_symlink were both uncovered.

Tests for get_next_base26 cover the increment/rollover cases directly (a->b, z->aa, az->ba, zz->aaa, etc) and invalid input. For create_unique_base26_symlink I mocked the filesystem calls (os.listdir, os.symlink, find_matching_symlink) instead of creating real symlinks, since that needs elevated privileges on Windows without Developer Mode - this still covers the existing-match short circuit, picking the next id after the highest existing one, the EEXIST retry-on-race path, non-EEXIST errors propagating, and giving up after too much contention.

Ran the full suite locally (332 passed), flake8 and ruff clean on the new file.

Refs #2092

---

Disclosure: Claude (Sonnet 5) was used to assist in writing the test code and drafting this commit message and PR description.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: darrenhuai / name: darrenhuai (47fe68d)

[maxnbk]

Hi @darrenhuai , thank you for the testing contribs.
Were these (this and previous PR) generated using LLMs?
If so, we need a disclosure in the PR title stating the LLM used and what they were used for.
This is in response to ASWF TAC discussions and will be added to our CONTRIBUTING.md shortly.
Thank you.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.34%. Comparing base (5c598c5) to head (22ab8f4).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2156      +/-   ##
==========================================
+ Coverage   61.29%   61.34%   +0.04%     
==========================================
  Files         164      164              
  Lines       20568    20568              
  Branches     3575     3576       +1     
==========================================
+ Hits        12607    12617      +10     
+ Misses       7089     7081       -8     
+ Partials      872      870       -2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[darrenhuai]

Yes, both PRs were AI-assisted. Claude assisted in writing the test code, and drafting the commit messages and PR descriptions. I reviewed the diffs and the test/lint output before pushing each one and made the call on what to ship. Happy to add a disclosure to the PR title, is there a format you'd prefer, since the policy isn't finalized yet? Thank you!

[maxnbk]

@darrenhuai Something as simple as what I'm putting on my PRs is fine for now, like this, in the PR description (not the title):

Disclosure: GLM-5.2 was used to assist in diagnostics, docstring, and test-writing. Or something to that effect.

Just to explain (as a point of reference), we're not barring LLM-generated code, it's just so that we the maintainers can:

1. Review MRs better, because humans and LLMs tend to make different kinds of mistakes that can require different attitudes when evaluating
2. Understand better how much LLM usage is helping devs/maintainers work on the project.

[darrenhuai]

perfect thank you! will do so

[JeanChristopheMorinPerso]

I threw a coding agent at your PR and it found two bugs in base26.py that would be very easy to fix in this PR if you want. I don't consider these blocking as they are probably corner cases.

[JeanChristopheMorinPerso]

Suggested change

	"os.listdir", return_value=['a', 'b', 'c']
	), patch(
	"os.path.islink", return_value=True
	), patch("os.symlink") as symlink:
	result = create_unique_base26_symlink("/pkgs", "/source/2.0")
	symlink.assert_called_once_with("/source/2.0", result)
	self.assertTrue(result.endswith('d'))
	"os.listdir", return_value=['a', 'b', 'c', 'z', 'aa']
	), patch(
	"os.path.islink", return_value=True
	), patch("os.symlink") as symlink:
	result = create_unique_base26_symlink("/pkgs", "/source/2.0")
	symlink.assert_called_once_with("/source/2.0", result)
	self.assertTrue(result.endswith('ab'))

Doing this will highlight that there's actually a bug in create_unique_base26_symlink. max(names) should be replaced with max(names, key=lambda x: (len(x), x)).

That's because:

>>> max(['z', 'aa'])
'z'

In other words, the tests have full coverage purely in terms of code, but not in terms of logic.

[JeanChristopheMorinPerso]

Suggested change

	for bad in ('A', 'a1', 'a-b', ' a', 'a '):
	with self.assertRaises(ValueError):
	get_next_base26(bad)
	for bad in ('A', 'a1', 'a-b', ' a', 'a '):
	with self.subTest(item=bad):
	with self.assertRaises(ValueError):
	get_next_base26(bad)

This will more clearly show that we are testing multiple things.

ALso, note how there's a but in the get_next_base26 where it accepts a trailing \n. We should replace match with fullmatch.

[darrenhuai]

@JeanChristopheMorinPerso both fixes are in as of 20e08b4 - apologies for pushing them without saying anything.

get_next_base26 now uses fullmatch instead of match, so a trailing newline is rejected rather than silently accepted. And create_unique_base26_symlink picks the previous name with max(names, key=lambda x: (len(x), x)), so 'aa' correctly counts as higher than 'z'. I took your test suggestions as well - the mixed-length listdir case is in as its own regression test, and the invalid-input loop uses subTest so a failure points at the specific bad value.

Worth flagging that this makes the PR no longer tests-only: it now touches src/rez/utils/base26.py. @maxnbk your approval predates that commit, so you may want another look at it.

Suite and linters were clean when I pushed.

[Copilot]

Pull request overview

Adds unit coverage for base-26 identifiers and symlink allocation while fixing validation and identifier ordering.

Changes:

• Tests increments, rollover, validation, symlink creation, and errors.
• Uses strict input matching.
• Orders mixed-length identifiers correctly.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
src/rez/utils/base26.py	Fixes validation and identifier ordering.
src/rez/tests/test_utils_base26.py	Adds comprehensive unit tests.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.