-
Notifications
You must be signed in to change notification settings - Fork 369
fix: windows drive letters remap to unc paths #2104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
d51ea2e
486b53c
6d74c1d
de5586c
bc8e5a9
745d371
575bf72
0139430
150effd
274fe00
2f66335
9f748bb
09a8584
30bbc32
43ca76e
8ca2817
f621d4d
98f4493
fad32a4
97703d5
11cca12
d49fab7
23be581
2d0151e
30f9a41
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -125,6 +125,26 @@ | |||||||||
| # For further information, see :ref:`package-definition-sharing-code`. | ||||||||||
| package_definition_python_path = None | ||||||||||
|
|
||||||||||
| # On Windows, whether to resolve symbolic links and junction points when | ||||||||||
| # normalising filesystem paths (primarily inside ``canonical_path``). | ||||||||||
| # | ||||||||||
| # When ``False`` (default), rez uses ``os.path.abspath``, which normalises | ||||||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do we need to mention |
||||||||||
| # separators and ``.``/``..`` components without following symlinks and without | ||||||||||
| # expanding mapped drive letters to their UNC equivalents. This preserves the | ||||||||||
| # path style supplied by the caller (drive-letter input, drive-letter output, | ||||||||||
| # UNC input, UNC output), effectively defaulting to pre-Python-3.8 behaviour of | ||||||||||
| # ``os.path.realpath`` on Windows. | ||||||||||
| # | ||||||||||
| # When ``True``, rez performs a component-by-component walk using | ||||||||||
| # ``os.path.islink`` / ``os.readlink``. This resolves actual symlinks and | ||||||||||
| # junction points without the drive-letter-to-UNC side-effect that | ||||||||||
| # ``os.path.realpath`` introduced in Python 3.8. Useful when package | ||||||||||
| # repositories are accessed through directory symlinks or junctions. | ||||||||||
| # | ||||||||||
| # This setting is a no-op on non-Windows platforms, which always resolve | ||||||||||
| # symlinks via ``os.path.realpath``. | ||||||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
(or whatever the next version will be) (I'll push a PR to add tests that will catch this problem moving forward). |
||||||||||
| resolve_links_on_windows = False | ||||||||||
|
|
||||||||||
|
|
||||||||||
| ############################################################################### | ||||||||||
| # Extensions | ||||||||||
|
|
||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(or something like that. I don't remember off the top of my head if you need to use the full absolute function name (
rez.utils.filesystem.canonical_path) or if sphinx will figure it out by itself.