-
Notifications
You must be signed in to change notification settings - Fork 369
Allow building with cmake on Windows #2090
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gabrieljreed
wants to merge
7
commits into
AcademySoftwareFoundation:main
Choose a base branch
from
gabrieljreed:fix-cmake-on-windows
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
0904b7c
Add support for non-pathed environment variables in path normalization
gabrieljreed 15efe75
Fix syntax in install_python macro
gabrieljreed ef4c9e6
Add VERBATIM in install_python macro
gabrieljreed 9ed8de8
Update documentation
gabrieljreed a1c40e1
PR review updates
gabrieljreed b33d7f4
Formatting fix
gabrieljreed f0ba2af
Improve py_compile step to ensure safety with backslashes or single q…
gabrieljreed File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
|
|
@@ -539,6 +539,15 @@ | |||||||
| "*PATH" | ||||||||
| ] | ||||||||
|
|
||||||||
| # This setting identifies environment variables that should not have path | ||||||||
| # normalization applied, even if they match a pattern in :data:`pathed_env_vars`. | ||||||||
| # This is useful for variables like ``CMAKE_MODULE_PATH`` which end in ``PATH`` | ||||||||
| # but require forward slashes regardless of the shell. Wildcards are supported. | ||||||||
|
JeanChristopheMorinPerso marked this conversation as resolved.
|
||||||||
| # Takes priority over :data:`pathed_env_vars`. | ||||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||
| non_pathed_env_vars = [ | ||||||||
| "CMAKE_*_PATH" | ||||||||
| ] | ||||||||
|
|
||||||||
| # Defines what suites on ``$PATH`` stay visible when a new rez environment is resolved. | ||||||||
| # Possible values are: | ||||||||
| # | ||||||||
|
|
||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.