Fix for combined packages on windows - #1759
Open
cfxegbert wants to merge 1 commit into
Open
Conversation
fix: check for None when normalizing paths
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1759 +/- ##
==========================================
- Coverage 58.41% 58.39% -0.02%
==========================================
Files 126 126
Lines 17163 17163
Branches 3506 3506
==========================================
- Hits 10025 10023 -2
- Misses 6473 6474 +1
- Partials 665 666 +1 ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
Can this be reviewed for inclusion in the next rez release? I currently have to patch rez when building for windows. |
Member
|
@cfxegbert Can you rebase the branch please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1758
See bug #1758 for detail explanation