Fix Ubuntu CI: X11 tablet clippy + cargo-deny wildcard/license - #1
Merged
Merged
Conversation
…go-deny which crates are internal Ubuntu clippy (pedantic on 1.95) was stricter than Mac on the X11 tablet backend: - doc_markdown on XInput2 / XI_ProximityIn,Out - cast_possible_truncation from Xlib c_ulong window XID down to x11rb's u32 Window (29-bit in practice, but narrow via try_from to say so) - struct_field_names on AxisAtoms (fields mirror X11 atom labels) - needless_pass_by_value on pump_loop's Arc args (take by reference) - cast_lossless on u8 -> DeviceId (u16) for proximity events - cast_possible_truncation on usize -> u16 valuator index (bail via try_from) - map_unwrap_or on three pressure / twist / tangential mappings - cast_possible_truncation on f64 -> f32 of normalized [0,1] and bounded degree values in build_sample / compute_tilt (expect-attributed with reason) cargo-deny on Ubuntu also failed: allow-wildcard-paths only applies to non-publishable crates, so every workspace crate that uses path-only workspace deps tripped the wildcard lint. Only stylus-junk is meant to be publishable; mark all the aj-* and aj-convert crates publish = false. Also drop MPL-2.0 and Unicode-DFS-2016 from the license allowlist — they were flagged as unmatched allowances and nothing in the dep tree uses them. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cfg(target_os = "linux").aj-*andaj-convertcratespublish = falseso cargo-deny'sallow-wildcard-pathsactually applies to their workspace path deps.stylus-junkstays publishable (it has no internal path deps).MPL-2.0andUnicode-DFS-2016fromdeny.toml's license allowlist — both were unmatched and noisy.Plan-format notes
idx = bit as u16cast became atry_fromwithelse { break }which keeps the loop early-exit pattern already used in the surrounding match.#[expect(...)]with areason = ...so future-self knows why each lint is suppressed.publish = falsepattern is the load-bearing fix — without it, every new internal crate that usesworkspace = truedeps would re-trip the wildcard ban.Test plan
cargo fmt --all -- --check(clean locally)cargo clippy --workspace --all-targets -- -D warnings(clean on macOS — Linux exercised via CI)🤖 Generated with Claude Code