fix: expose actionable leaderboard score errors - #244
Draft
JoelFerrando wants to merge 2 commits into
Draft
Conversation
Contributor
Author
|
Android verification is now complete: an authenticated global load succeeded on a physical device, and rejecting the real Play Games friends-list consent sheet returned |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SIGN_IN_REQUIREDbyApiException.statusCode, without parsing localized messagesGKError.notAuthenticatedandGKError.cancelledto stable codesLeaderboardScoresErrorCodeconstants through the Dart packageWhy
loadLeaderboardScorescurrently collapses native failures intofailed_to_load_leaderboard_scores. Callers cannot distinguish an expired sign-in session, a declined friends-list request, or a canceled GameKit operation from an unknown service failure.This supersedes only the leaderboard portion accidentally included in #238. It deliberately avoids localized-message matching and does not classify
GKError.cancelledas a consent error.Verification
SIGN_IN_REQUIRED,DEVELOPER_ERROR, and non-ApiExceptionfailures::games_services:testDebugUnitTestpassesfriends_list_access_deniedwithPlayer declined friends list accessfailed_to_load_leaderboard_scores; this verifies that configuration/developer failures are not misclassified as authentication-requireddart analyzeingames_services_platform_interface: cleanflutter analyze --no-fatal-warningsingames_services: only the existing developmentpathdependency warningStill to verify before marking ready: