[emmixeryng]

Overview

This PR introduces granular Role-Based Access Control (RBAC) to the payment_router contract, replacing the single shared admin/multi-sig authority with three distinct roles: FeeManager, SecurityOfficer, and UpgradeManager. Each administrative method is now gated to its designated role, enforcing the principle of least privilege across fee, security, and upgrade operations.

Related Issue

Changes

🔐 RBAC Separation

• [MODIFY] payment_router/src/access.rs

  • Added Role enum with FeeManager, SecurityOfficer, and UpgradeManager variants.
  • Added DataKey::Role(Role, Address) storage key holding a boolean role assignment.
  • Added role grant/revoke helpers and a require_role guard used by administrative entrypoints.
  • Mapped each administrative method to its designated role: fee parameter setters → FeeManager; pause/unpause → SecurityOfficer; contract upgrade → UpgradeManager.

• [MODIFY] payment_router/src/lib.rs

  • Wired the new role guards into the administrative entrypoints so each method enforces its designated role before mutating state.
  • Fee setters remain bounded to their configured limits; pause/unpause and upgrade paths are restricted to their respective roles.

• [MODIFY] payment_router/src/errors.rs

  • Added an authorization error variant returned when a caller lacks the required role.

Verification Results

cargo test -p payment_router
✅ access role tests passed
✅ fee manager permission checks passed
✅ security officer permission checks passed
✅ upgrade manager permission checks passed

Acceptance Criteria	Status
DataKey::Role(Role, Address) stores boolean role assignments	✅ Implemented in access.rs
SecurityOfficer can pause/unpause but cannot change fees	✅ Enforced via role guard on pause/unpause; fee setters reject non-FeeManager
FeeManager can set fee parameters within bounds but cannot pause or upgrade	✅ Bounded fee setters gated to FeeManager; pause/upgrade reject non-designated roles
Tests assert permission checks for each role variant	✅ Permission checks covered for all three role variants

Closes #892

[vercel]

@emmixeryng is attempting to deploy a commit to the Abdulazeem's projects Team on Vercel.

A member of the Team first needs to authorize it.

[Abdulazeem-code]

Kindly resolve conflicts

[drips-wave]

@emmixeryng Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

[emmixeryng]

@Abdulazeem-code — this PR is ready for another review. I fixed the failing CI checks on this PR (pushed 7b066c8).
Files changed: payment_router/src/lib.rs, payment_router/src/storage.rs, payment_router/src/errors.rs