Testing a proof-of-concept fix for the duplicate GATT service issue. - #36
Open
alwentiu wants to merge 1 commit into
Open
Testing a proof-of-concept fix for the duplicate GATT service issue.#36alwentiu wants to merge 1 commit into
alwentiu wants to merge 1 commit into
Conversation
- In ConcreteBLETransmitter.kt, make sure services are cleard and GATT server closed (if it exists) - In BluetoothMonitoringService.kt, make sure no duplicate SensorArray objects are created. DISCLAIMER: This modification is meant to demonstrate a diagnosis of the root cause of the issue; it is not meant as a definitive fix.
|
This fix looks good, but I think there might still be one extra step required to solve the duplicate RPAs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is related to Issue #33 (duplicate GATT service registered). I think there are two separate issues:
The modifications I did:
DISCLAIMER: This modification is meant to demonstrate a diagnosis of the root cause of the issue; it is not meant as a definitive fix. Further tests will be required.