Repository navigation
feat: implement NotificationDispatcher with wildcard routing and tests - #364
Merged
Cjay-Cyber-2 merged 1 commit intoOct 7, 2026
Conversation
Contributor
CI Checks Failed - Action Needed. build and typecheck pass, but lint fails on three @typescript-eslint/no-explicit-any violations: packages/notification/src/dispatcher.test.ts line 180, and packages/notification/src/dispatcher.ts lines 103 and 190. Replace the broad any types with the appropriate concrete or unknown-based types, or add a narrowly justified lint suppression, then rerun CI. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implemented lightweight, isomorphic NotificationDispatcher in @astroid/notification supporting exact, single-segment (*), and multi-segment (**, #) topic subscriptions, async/sync dispatch, and comprehensive unit tests.
Type of change
Related issue
Closes #12
Checklist
pm run build\ passes
pm run typecheck\ passes
pm run lint\ passes