Skip to content

Expand risk coverage and harden webhook failures - #453

Open
amina69 wants to merge 1 commit into
ASTROIDX556:mainfrom
amina69:fix/issues-424-425-433-434
Open

amina69 wants to merge 1 commit into
ASTROIDX556:mainfrom
amina69:fix/issues-424-425-433-434

Conversation

@amina69

@amina69 amina69 commented Oct 20, 2026

Copy link
Copy Markdown

Summary

  • Expand RiskService tests to cover event, fallback, deduplication, and repository paths; focused branch coverage is 100%.
  • Make webhook retry limits configurable, persist terminal unrecoverable failures, and emit a typed permanent-failure domain event.
  • Safely serialize circular error details in the existing globally registered exception filter.

Validation

  • npm test (1,834 tests passed across 169 files)
  • npm run test:cov
  • npm run typecheck

Closes #424
Closes #425
Closes #433
Closes #434

@drips-wave

drips-wave Bot commented Oct 20, 2026

Copy link
Copy Markdown

@amina69 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@Cjay-Cyber-2

Copy link
Copy Markdown
Contributor

The branch now conflicts with current main across transaction/webhook/risk changes. I am holding it rather than guessing at behavior-changing conflict resolution; please rebase the branch onto main, resolve the conflicts, and rerun the green CI checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants