Repository navigation
The assemblies carry the release's version, not 2.3.0 - #1679
Merged
Merged
Conversation
Nuget.yml passed the release's version as PackageVersion, which names a package but not the assemblies in it, and those took Version and FileVersion from Package.Build.props, which said 2.3.0. Both release workflows now pass Version and FileVersion, and the props name 2.6.0, the version under development, for a local build. Closes #1678. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012sonx8iAspMiwRwokT1Ura
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1678.
Nuget.ymlpassed the release's version asPackageVersion, which names a package but not the assemblies in it. Those tookVersionandFileVersionfromPackage.Build.props, which said 2.3.0, so the 2.5.0 package'sAngouriMath.dllreports2.3.0+ab7a8bd6….Nuget.ymlpassesVersionandFileVersionto each build and pack.PackageVersionfollowsVersion.publish.shdoes the same withTERMINAL_VERSION, for the self-contained terminal builds.Package.Build.propsnames 2.6.0, the version under development, for a local build.FileVersionis four numbers, so it is the version without its suffix, followed by.0.Checked by building and packing the library as the workflow does, with
-p:Version=2.6.0-rc.1 -p:FileVersion=2.6.0.0:AngouriMath.2.6.0-rc.1.nupkg;AngouriMath.dllcarries the informational version2.6.0-rc.1+be009d56…and the file version2.6.0.0.The publish script was dry-run with
TERMINAL_VERSION=2.6.0-rc.1and without it.TerminalNightly.ymlruns on this PR, since it touchespublish.sh.🤖 Generated with Claude Code
https://claude.ai/code/session_012sonx8iAspMiwRwokT1Ura