Enable clean macOS Apple Silicon builds with Apple Clang and Homebrew GCC - #2
Open
bglenden wants to merge 1 commit into
Open
Enable clean macOS Apple Silicon builds with Apple Clang and Homebrew GCC#2bglenden wants to merge 1 commit into
bglenden wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the changes needed to build LibRA cleanly on current macOS (26.4) on Apple Silicon.
The work covers both macOS toolchain paths I was able to exercise locally:
What changed
The macOS bring-up required a mix of build-system and source-compatibility fixes, including:
ExternalProjectdependencieslibompcasacore,parafeed,FFTW,HPG,Kokkos, andpybind11std::unary_function,std::binary_function,std::bind2nd,std::mem_fun,std::mem_fun_ref, andstd::not1Validation
This branch builds cleanly on macOS 26.4 on Apple Silicon with both:
I verified the full top-level build and install path locally.
I also let a Linux smoke build run to completion in the local Docker Desktop VM using Ubuntu 24.04 on
linux/arm64(Apple Silicon). That is useful additional coverage for the Linux path, but it is ARM rather than x86_64.Testing
I was not able to run the repo's dataset-backed tests because the
apps/src/tests/gold_standardtest data could not be located from the repository contents or submodule wiring currently visible from my fork.If the maintainers let me (BG) know where to obtain the
gold_standarddata, I would be happy to run the tests and report back, with the caveat that I only have access to relatively low-end Mac hardware.Notes
I also included an
AGENTS.mdfile with repository-specific build notes for AI coding assistants, in case that is of interest to the project.