Skip to content

fix: utilizing favicon in .ico and .svg format to try fix the search indexing icon issue#732

Open
reach2saksham wants to merge 2 commits into
AOSSIE-Org:mainfrom
reach2saksham:bug/favicon
Open

fix: utilizing favicon in .ico and .svg format to try fix the search indexing icon issue#732
reach2saksham wants to merge 2 commits into
AOSSIE-Org:mainfrom
reach2saksham:bug/favicon

Conversation

@reach2saksham

@reach2saksham reach2saksham commented Jul 7, 2026

Copy link
Copy Markdown
Member

Description

This PR resolves the issue where the AOSSIE logo was not displaying in Google Search results by properly defining favicon link tags and ensuring the SVG format complies with Google's search requirements.

Changes Made

  • Added Favicon Metadata: Configured the icons field in the root metadata object of src/app/layout.jsx to generate explicit tags pointing to /favicon.ico and /favicon.svg. (Google Search crawler requires these tags to find and cache the favicon).
  • Standardized SVG Aspect Ratio: Modified public/favicon.svg to be a perfect 1:1 square (500x500 viewBox) to comply with Google's square-only requirement, while keeping the graphic centered.

Note to Mentor

Google Search takes some time to update search result favicons on its own. To speed this up, please request a re-index of the homepage:

  • Open Google Search Console for aossie.org.
  • Enter the homepage URL in the URL Inspection tool.
  • Click Request Indexing.

Note: As a GSoC contributor, I cannot request this indexing myself because Google Search Console requires verified domain ownership.

AI Usage Disclosure:

We encourage contributors to use AI tools responsibly when creating Pull Requests. While AI can be a valuable aid, it is essential to ensure that your contributions meet the task requirements, build successfully, include relevant tests, and pass all linters. Submissions that do not meet these standards may be closed without warning to maintain the quality and integrity of the project. Please take the time to understand the changes you are proposing and their impact. AI slop is strongly discouraged and may lead to banning and blocking. Do not spam our repos with AI slop.

Check one of the checkboxes below:

  • This PR does not contain AI-generated code at all.
  • This PR contains AI-generated code. I have read the AI Usage Policy and this PR complies with this policy. I have tested the code locally and I am responsible for it.

I have used the following AI models and tools: TODO

Checklist

  • My PR addresses a single issue, fixes a single bug or makes a single improvement.
  • My code follows the project's code style and conventions
  • If applicable, I have made corresponding changes or additions to the documentation
  • If applicable, I have made corresponding changes or additions to tests
  • My changes generate no new warnings or errors
  • I have joined the Discord server and I will share a link to this PR with the project maintainers there
  • I have read the Contribution Guidelines
  • Once I submit my PR, CodeRabbit AI will automatically review it and I will address CodeRabbit's comments.
  • I have filled this PR template completely and carefully, and I understand that my PR may be closed without review otherwise.

Summary by CodeRabbit

  • New Features
    • Added site icon support in the app’s metadata, including favicon and Apple touch icon entries.
    • Improved how the app identifies itself across browser tabs and on Apple devices.

@coderabbitai

coderabbitai Bot commented Jul 7, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@reach2saksham, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 51 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 3ea6d56a-e2ab-4790-ad93-b1f6a9cc7ea5

📥 Commits

Reviewing files that changed from the base of the PR and between e2c9608 and 0b4f0c8.

⛔ Files ignored due to path filters (1)
  • public/favicon.png is excluded by !**/*.png
📒 Files selected for processing (1)
  • src/app/layout.jsx
📝 Walkthrough

Walkthrough

G'day! This one's a real quick fix - the metadata export in src/app/layout.jsx now carries an icons field, wiring up favicon.ico and favicon.svg as standard icons plus favicon.svg as the apple touch icon.

Changes

Favicon Configuration

Layer / File(s) Summary
Add favicon metadata entries
src/app/layout.jsx
The metadata export gains an icons object specifying icon entries (favicon.ico and favicon.svg) and an apple icon pointing to favicon.svg.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Poem:

A wallaby hopped by the code, quick as can be,
Added some icons for all folks to see,
Favicon.ico and svg, side by side,
Apple gets a little icon too, no need to hide,
Small as a shrimp on the barbie, tidy as can be!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches the main change: adding favicon support for .ico and .svg to address search indexing issues.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/app/layout.jsx`:
- Around line 44-50: The app icons metadata in the layout’s icons config is
using an SVG for the apple touch icon, which iOS/Safari and Next app-icons won’t
use. Update the `icons` object in the layout metadata so the `icon` entries keep
the SVG, but the `apple` value points to a PNG apple-touch icon asset (typically
180×180) that can be resolved by the app-icons handling.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 4e9bfa6a-d83f-4c7b-8e06-1914acda69f2

📥 Commits

Reviewing files that changed from the base of the PR and between 895772c and e2c9608.

⛔ Files ignored due to path filters (1)
  • public/favicon.svg is excluded by !**/*.svg
📒 Files selected for processing (1)
  • src/app/layout.jsx

Comment thread src/app/layout.jsx
@reach2saksham reach2saksham self-assigned this Jul 7, 2026
@reach2saksham reach2saksham added the bug Something isn't working label Jul 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant