fix/ Fixes issue of project card routing and makes the cards more interactive#731
fix/ Fixes issue of project card routing and makes the cards more interactive#731Swap-24 wants to merge 2 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughAdds Project Card Hover & Navigation
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
src/app/page.jsx (1)
222-235: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winKeyboard/touch users get the scale effect but never the card flip.
The new
onFocus/onBlurhandlers drive the hover scale state, but the card’s face flip is bound togroup-hoveronly (inCardEffect.jsx). So keyboard and touch users can focus/navigate a card yet never see the back-face description. Since the cards are now interactive links, consider adding agroup-focus/group-focus-withinvariant to the flip transform so the description is reachable without a mouse.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/app/page.jsx` around lines 222 - 235, The card flip in CardEffect is only triggered by the mouse hover state, so keyboard/touch users can focus the link but never reveal the back face. Update the flip behavior in CardEffect.jsx to also react to focus-based states by adding a group-focus or group-focus-within variant alongside group-hover, and make sure the link wrapper in src/app/page.jsx supports that focus state so the description is reachable without a mouse.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@src/app/page.jsx`:
- Around line 222-235: The card flip in CardEffect is only triggered by the
mouse hover state, so keyboard/touch users can focus the link but never reveal
the back face. Update the flip behavior in CardEffect.jsx to also react to
focus-based states by adding a group-focus or group-focus-within variant
alongside group-hover, and make sure the link wrapper in src/app/page.jsx
supports that focus state so the description is reachable without a mouse.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 7184573d-bf3a-41ae-8ba2-fed93000e087
📒 Files selected for processing (2)
src/app/page.jsxsrc/components/home/CardEffect.jsx
Addressed Issues:
Fixes #726
Fixed the project cards in the landing page of the website so that clicking on them directly navigates the user to the corresponding project link. Also took a little bit of stylistic liberty to add a hover/focus interaction where the hovered card becomes slightly larger while the other cards become slightly smaller and move away, making the project section feel more interactive. Also ensured safety by opening external project links in a new tab with
noopener noreferrer.Screenshots/Recordings:
After the fix:
https://github.com/user-attachments/assets/28d5a83b-d820-4cfa-a31c-5142d9d89695
Additional Notes
src/helper/projects.jsand passed them as props inside theCardEffectcomponent insrc/app/pages.jsxfamer-motionon thenext/linkcomponentChecklist
Summary by CodeRabbit
Summary by CodeRabbit
New Features
Bug Fixes