Fix capture storage reclaim - #432
Merged
Merged
Conversation
yueliu14
approved these changes
Aug 26, 2026
zihaoanllm
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #429: process-local
capture.pid-*directories each retaining a fullreference_io.ptwere not reclaimed after selection/finalize, which could blow ephemeral disk (~128Gi) under multi-rank / retry capture.This PR:
meta.json+reference_io.ptto the task root, then deletes process-localcapture.pid-*dirs (promote_and_reclaim/ selection--task-dir).CAPTURE_BYTE_BUDGET,CAPTURE_CASE_BYTE_LIMIT,CAPTURE_PERSIST_POLICY=share_large) and finalize-time--reclaim-workspace.EXTRA_ENVfrome2e_workflow.js, and reclaims leftover captures before Finalize (kept across merge withmain, alongsideTIME_FINAL_DEADLINE_HIT).Test plan
CI
Result (2026-08-26, tip after merge with
main):134 passed, 51 subtests passed in 1.13sThese L0 suites cover #429 unit behavior (promote/reclaim, budget skip,
share_large, selection reclaim). Please also let GitHub Actions L0 re-run on the PR.Offline deep tests — conclusions (issue-fix evidence)
69/69 PASS. The fix is demonstrated by behavior, not only by green status:
capture.pid-*dirs are gone.bytes_reclaimed; workspace size shrinks after reclaim (example: ~18.9MB → ~2.1MB).share_largewrites a complete oracle that is smaller thanfull(example: 48.4MiB → 16.4MiB) while still capturing the same case count, with a shared tensor pool.Hyperloom E2E — conclusions (issue-fix evidence)
Real KERNEL-phase run on this fix branch (Qwen3-14B-FP8 / sglang / MI355X), with continuous #429 monitoring during extract/capture:
capture.pid-*dir at a time; zero ticks with multiple captures under the same task.reference_ioartifacts landing outside the session GEAK worktree;CAPTURE_OUTstayed under the expected task path.How to review
e2e_workflow/scripts/capture_shapes.py— budgets,share_large,promote_and_reclaim,--reclaim-workspacee2e_workflow/scripts/kernel_selection.py— task-dir promote/reclaim after selectione2e_workflow/e2e_workflow.js—CAPTURE_STORAGE_ENVinjection + Finalize reclaim (merged withmaintime-budget gate)test_capture_shapes.py/test_kernel_selection.pymarked for issue Process-local capture artifacts can grow the workspace until ephemeral-storage eviction #429